Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: ext/popup.js

Issue 29458601: Issue 5315 - Add support for Microsoft Edge (Closed)
Left Patch Set: Future proof in case Edge supports OBJECT request interception Created June 28, 2017, 4:30 p.m.
Right Patch Set: Cosmetic changes Created July 28, 2017, 11:02 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « ext/common.js ('k') | icons/abp-150.png » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 "use strict"; 1 "use strict";
2 2
3 (function() 3 (function()
4 { 4 {
5 if (!chrome || !chrome.extension) 5 if (typeof chrome == "undefined" || typeof chrome.extension == "undefined")
6 window.chrome = browser; 6 window.chrome = browser;
7 const backgroundPage = chrome.extension.getBackgroundPage(); 7 const backgroundPage = chrome.extension.getBackgroundPage();
8 window.ext = Object.create(backgroundPage.ext); 8 window.ext = Object.create(backgroundPage.ext);
9 9
10 window.ext.closePopup = () => 10 window.ext.closePopup = () =>
11 { 11 {
12 window.close(); 12 window.close();
13 }; 13 };
14
15 // Calling i18n.getMessage from the background page causes Edge to throw an
16 // exception.
17 // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/127939 75/
18 window.ext.i18n = chrome.i18n;
14 19
15 // We have to override ext.backgroundPage, because in order 20 // We have to override ext.backgroundPage, because in order
16 // to send messages the local "chrome" namespace must be used. 21 // to send messages the local "chrome" namespace must be used.
17 window.ext.backgroundPage = { 22 window.ext.backgroundPage = {
18 sendMessage: chrome.runtime.sendMessage, 23 sendMessage: chrome.runtime.sendMessage,
19 24
20 getWindow() 25 getWindow()
21 { 26 {
22 return backgroundPage; 27 return backgroundPage;
23 } 28 }
24 }; 29 };
25 }()); 30 }());
LEFTRIGHT

Powered by Google App Engine
This is Rietveld