Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/common.js

Issue 29458601: Issue 5315 - Add support for Microsoft Edge (Closed)
Patch Set: Make copyProperties more generic Created June 21, 2017, 11:34 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ext/common.js
===================================================================
--- a/ext/common.js
+++ b/ext/common.js
@@ -19,6 +19,13 @@
(function()
{
+ // Both Edge and Mozilla Web Extensions use the namespace
+ // 'browser' instead of 'chrome'. Edge has chrome namespace defined,
+ // but only with one property: 'app'.
+ if (typeof chrome == "undefined" ||
kzar 2017/06/22 11:23:38 Nit: Personally I would have just done `if (!chrom
Oleksandr 2017/06/22 13:34:59 Done.
+ typeof chrome.extension == "undefined")
+ window.chrome = window.browser;
+
window.ext = {};
let EventTarget = ext._EventTarget = function()

Powered by Google App Engine
This is Rietveld