Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: inject.preload.js

Issue 29458601: Issue 5315 - Add support for Microsoft Edge (Closed)
Patch Set: Rebase to current tip Created July 27, 2017, 9:45 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: inject.preload.js
===================================================================
--- a/inject.preload.js
+++ b/inject.preload.js
@@ -174,8 +174,11 @@
{
for (let name of properties)
{
- Object.defineProperty(dest, name,
- Object.getOwnPropertyDescriptor(src, name));
+ if (src.hasOwnProperty(name))
+ {
+ Object.defineProperty(dest, name,
+ Object.getOwnPropertyDescriptor(src, name));
+ }
}
}
@@ -375,6 +378,7 @@
WrappedRTCPeerConnection.prototype = RealRTCPeerConnection.prototype;
let boundWrappedRTCPeerConnection = WrappedRTCPeerConnection.bind();
+ // NOTE: Edge does not support generateCertificate
kzar 2017/07/28 10:38:57 Nit: Mind removing this comment? I don't think it
copyProperties(RealRTCPeerConnection, boundWrappedRTCPeerConnection,
["generateCertificate", "name", "prototype"]);
RealRTCPeerConnection.prototype.constructor = boundWrappedRTCPeerConnection;

Powered by Google App Engine
This is Rietveld