Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: includes/index.tmpl

Issue 29458622: Issue 4920 - Add "Ready for Windows" section to adblockplus.org (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Created June 7, 2017, 2:53 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | static/css/index.css » ('j') | static/css/index.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: includes/index.tmpl
===================================================================
--- a/includes/index.tmpl
+++ b/includes/index.tmpl
@@ -161,16 +161,21 @@
<div class="sprite" id="facts-privacy"></div>
<h1>{{"Privacy Guaranteed"|translate("s48")}}</h1>
<p>
{{"Adblock Plus will never collect your <a href=\"privacy\">personal data</a>."|translate("privacy-policy-note")}}
</p>
</section>
</div>
+
juliandoucette 2017/06/07 17:48:11 I know that I told you that you could show/hide ba
ire 2017/06/08 13:41:26 Okay. I like that better than hiding with CSS so I
juliandoucette 2017/06/16 18:19:02 :+1: Note: I asked Ollie if this applies to Edge
+<div id="ready-for-windows-note">
juliandoucette 2017/06/07 17:48:11 Why not place the `id` on the `<p>` and drop the `
juliandoucette 2017/06/07 17:48:11 NIT: I don't think "note" is descriptive (Ack: You
ire 2017/06/08 13:41:26 Okay, I'll go with "ready-for-windows-notice".
ire 2017/06/08 13:41:26 Will do.
+ <p>{{"Adblock Plus for Internet Explorer is supported by eyeo GmbH on the following editions of Windows 10 – Windows 10 Pro, Windows 10 Education and Windows 10 Enterprise. Adblock Plus for Internet Explorer is supported on the in-market supported servicing branches of Windows 10 including - Current Branch, Current Branch for Business and the following Long-Term Servicing branch: Windows 10."|translate("ready-for-windows-note")}}</p>
juliandoucette 2017/06/07 17:48:11 Don't forget to `<fix>` product / brand names.
ire 2017/06/08 13:41:26 Okay. I mentioned this in the translation string d
juliandoucette 2017/06/08 21:12:30 Good questions. I know we fix all of "Internet E
juliandoucette 2017/06/16 18:16:16 (Moving the discussion that was in reply back to r
+</div>
+
<hr>
<div id="footnote">
[1] {{"The following rules <strong>have</strong> and <strong>always will</strong> apply to everyone, without exception:"|translate("footnote-headline")}}
<ul>
<li>
{{"Participants cannot pay to avoid the <a href=\"acceptable-ads#criteria-general\">criteria</a>. Every ad must comply."|translate("footnote-must-comply")}}
</li>
<li>
« no previous file with comments | « no previous file | static/css/index.css » ('j') | static/css/index.css » ('J')

Powered by Google App Engine
This is Rietveld