Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: update-copyright/.cache/v/cache/lastfailed
Issue
29459580
:
Issue 5250 - Add copyright update script (Closed)
Base URL: https://hg.adblockplus.org/codingtools
Patch Set: Addressed comments
Created June 23, 2017, 2:36 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Addressed comments
Patch Set 3: Addressed more comments
Patch Set 4: Clean up comments, ReadMe, formatting
Patch Set 5: Minor formatting fixes
Patch Set 6: Also test strings and non-eyeo copyright info
Patch Set 7: Remove the wrapper
Patch Set 8: Remove bash script, make Python script executable
Patch Set 9: Fix indentation and default args
Right:
Patch Set 1: None
Patch Set 2: Addressed comments
Patch Set 3: Addressed more comments
Patch Set 4: Clean up comments, ReadMe, formatting
Patch Set 5: Minor formatting fixes
Patch Set 6: Also test strings and non-eyeo copyright info
Patch Set 7: Remove the wrapper
Patch Set 8: Remove bash script, make Python script executable
Patch Set 9: Fix indentation and default args
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.hgignore
update-copyright/.cache/v/cache/lastfailed
update-copyright/README.md
update-copyright/tests/data/hg_page.html
update-copyright/tests/data/sample_file.py
update-copyright/tests/test_update_copyright.py
update-copyright/tox.ini
update-copyright/update_copyright.py
View unified diff
|
Download patch
« no previous file with comments
|
« .hgignore
('k') |
update-copyright/README.md »
('j') |
update-copyright/tests/test_update_copyright.py »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{}
Vasily Kuznetsov
2017/06/27 16:18:50
This file should be ignored too. Probably the best
This file should be ignored too. Probably the best approach is to ignore all `.cache` directories.
rosie
2017/07/03 15:33:43
Done.
Show quoted text
On 2017/06/27 16:18:50, Vasily Kuznetsov wrote: > This file should be ignored too. Probably the best approach is to ignore all > `.cache` directories.
Done.
OLD
NEW
« no previous file with comments
|
« .hgignore
('k') |
update-copyright/README.md »
('j') |
update-copyright/tests/test_update_copyright.py »
('J')
Edit Message
Issue 29459580: Issue 5250 - Add copyright update script (Closed)
Created June 8, 2017, 1:39 p.m. by rosie
Modified July 17, 2017, 3:49 p.m.
Reviewers: Vasily Kuznetsov, Jon Sonesen, Sebastian Noack
Base URL: https://hg.adblockplus.org/codingtools
Comments: 164
This is Rietveld