update-copyright/tox.ini - Issue 29459580: Issue 5250 - Add copyright update script

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: update-copyright/tox.ini

Issue 29459580: Issue 5250 - Add copyright update script (Closed) Base URL: https://hg.adblockplus.org/codingtools

Patch Set: Minor formatting fixes Created July 4, 2017, 3:13 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 [tox]

	2 envlist = py{35,36}

	3 skipsdist = True

	4

	5 [testenv]

	6 setenv =

	7 PYTHONPATH = {toxinidir}

	8

	9 deps =

	10 pytest

	11 flake8-putty
	Sebastian Noack 2017/07/05 18:55:21 You don't seem to actually use flake8-putty here. You don't seem to actually use flake8-putty here. You probably have copied this over from the tox.ini in sitescripts, buildtools or cms, where we use flake8-putty in order to ignore specific flake8 errors for specific files, in order to deal with legacy code. This isn't the case here. However, you should add pep8-naming and flake8-eyeo instead, as we use these flake8 extensions everywhere. For example see this tox.ini: https://hg.adblockplus.org/codingtools/file/d95b8d1f3104/patchconv/tox.ini#l9 rosie 2017/07/07 15:55:48 Done. Show quoted text On 2017/07/05 18:55:21, Sebastian Noack wrote: > You don't seem to actually use flake8-putty here. You probably have copied this > over from the tox.ini in sitescripts, buildtools or cms, where we use > flake8-putty in order to ignore specific flake8 errors for specific files, in > order to deal with legacy code. This isn't the case here. However, you should > add pep8-naming and flake8-eyeo instead, as we use these flake8 extensions > everywhere. For example see this tox.ini: > https://hg.adblockplus.org/codingtools/file/d95b8d1f3104/patchconv/tox.ini#l9 Done.
	12 pytest-cov

	13

	14 commands =

	15 pytest --cov=update_copyright tests

	16 flake8 update_copyright.py tests

OLD	NEW