Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: breakdown.md

Issue 29464633: No Issue - Help Center Development Breakdown (Closed)
Left Patch Set: Created June 13, 2017, 2:35 p.m.
Right Patch Set: Remove Search results page and template Created June 21, 2017, 8:33 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # Help Center Development Breakdown 1 # Help Center Development Breakdown
2 2
3 [Specification](https://bitbucket.org/adblockplus/spec/src/5eef1222584c3a04802bd 523d293f0bb58a5b5e4/spec/help-center/help-center.md?fileviewer=file-view-default ) 3 [Specification](https://bitbucket.org/adblockplus/spec/src/5eef1222584c3a04802bd 523d293f0bb58a5b5e4/spec/help-center/help-center.md?fileviewer=file-view-default )
4 4
5 5
6 ## Pages 6 ## Pages
7 7
8 - Home
ire 2017/06/13 14:37:49 This page isn't part of the current version
juliandoucette 2017/06/16 16:21:31 We can remove this from the specification of this
ire 2017/06/19 14:09:02 Acknowledged.
9 - Adblock Plus Home, help.eyeo.com/adblockplus 8 - Adblock Plus Home, help.eyeo.com/adblockplus
10 - Single Article Page, e.g. help.eyeo.com/adblockplus/block-all-ads 9 - Single Article Page, e.g. help.eyeo.com/adblockplus/block-all-ads
11 - Search Results Page
12 - Imprint, help.eyeo.com/legal 10 - Imprint, help.eyeo.com/legal
13 11
14 12
15 ## Templates 13 ## Templates
16 14
17 - Help Center Home 15 - Default Template
juliandoucette 2017/06/16 16:21:32 See comment above.
ire 2017/06/19 14:09:02 Acknowledged.
18 - Product Help Home 16 - Product Help Home
19 - Single Article 17 - Single Article
20 - Search Results
21 - Basic Page 18 - Basic Page
juliandoucette 2017/06/16 16:21:31 - This can be the default template - Other templat
ire 2017/06/19 14:09:02 Yes we should have a default template, but here I
22 19
23 20
24 ## Components 21 ## Components
25 22
26 - General Navigation 23 - Site Header
27 - Site Search Bar 24 - Site Footer
juliandoucette 2017/06/16 16:21:31 NIT: This is a field not a bar.
ire 2017/06/19 14:09:02 Acknowledged.
25 - Site Search Field
28 - Topics Group 26 - Topics Group
29 - Contact Section 27 - Contact Section
30 - Breadcrumb 28 - Breadcrumbs
juliandoucette 2017/06/16 16:21:32 NIT: Breadcrumb**s** or Breadcrumb bar?
ire 2017/06/19 14:09:02 I think "Breadcrumbs"
31 - Accordion Menu 29 - Accordion Menu
32 - Browser Selector with Browser Detection 30 - Browser Selector with Browser Detection
33 - Card 31 - Card
34 - Search Result Item 32 - Search Result Item
35 - Lists (Ordered Lists, Unordered Lists, "Numbered" Lists) 33 - Lists (Ordered Lists, Unordered Lists, "Numbered" Lists, "Underlined" Lists)
juliandoucette 2017/06/16 16:21:31 It's not clear to me whether there should also be
ire 2017/06/19 14:09:02 Yes you're right there's definitely a pattern ther
36 34
37 - Grid 35 - Grid
38 - Variables 36 - Variables
39 - Typography 37 - Typography
40 38
41 39
42 ### General Navigation 40 ### Site Header
43 41
44 [See Spec](https://bitbucket.org/adblockplus/spec/src/5eef1222584c3a04802bd523d2 93f0bb58a5b5e4/spec/help-center/help-center.md?fileviewer=file-view-default#mark down-header-general-navigation) 42 [See Spec](https://bitbucket.org/adblockplus/spec/src/5eef1222584c3a04802bd523d2 93f0bb58a5b5e4/spec/help-center/help-center.md?fileviewer=file-view-default#mark down-header-general-navigation)
45 43
46 This includes: 44 This includes:
juliandoucette 2017/06/16 16:21:31 Why did you group the header navbar and the footer
ire 2017/06/19 14:09:02 Yeah they will be separate includes. I was mostly
47 - Logo (in header) 45 - Logo
48 - Product Website Link (in header) 46 - Site Search Field
49 - Language Selector (in footer) 47 - Product Website Link
50 - Footer Links (in footer)
51 48
52 Note: The header has a slighlty different layout depening on if it is within a s pecific product's page (e.g. Single Article) or a general page (e.g. Basic Page) 49 Note: The header has a slighlty different layout depening on if it is within a s pecific product's page (e.g. Single Article) or a general page (e.g. Basic Page)
juliandoucette 2017/06/16 16:21:32 Thanks for pointing this out.
ire 2017/06/19 14:09:02 You're welcome :)
50
51
52 ### Site Footer
53
54 This includes:
55 - Language Selector
56 - Footer Links
53 57
54 58
55 ### Topics Group 59 ### Topics Group
56 60
57 This is a list of topics. There are two instances: 61 This is a list of topics. There are two instances:
58 62
59 - Within a card, e.g. the "Popular Topics" ([See Spec](https://bitbucket.org/adb lockplus/spec/src/5eef1222584c3a04802bd523d293f0bb58a5b5e4/spec/help-center/help -center.md?fileviewer=file-view-default#markdown-header-popular-topics)) 63 - Within a card, e.g. the "Popular Topics" ([See Spec](https://bitbucket.org/adb lockplus/spec/src/5eef1222584c3a04802bd523d293f0bb58a5b5e4/spec/help-center/help -center.md?fileviewer=file-view-default#markdown-header-popular-topics))
60 - Within a group of other "Topics Groups", e.g. on the Product Help Home page ([ See Spec](https://bitbucket.org/adblockplus/spec/src/5eef1222584c3a04802bd523d29 3f0bb58a5b5e4/spec/help-center/help-center.md?fileviewer=file-view-default#markd own-header-help-categories)) 64 - Within a group of other "Topics Groups", e.g. on the Product Help Home page ([ See Spec](https://bitbucket.org/adblockplus/spec/src/5eef1222584c3a04802bd523d29 3f0bb58a5b5e4/spec/help-center/help-center.md?fileviewer=file-view-default#markd own-header-help-categories))
61 65
62 66
63 ### Lists 67 ### Lists
64 68
65 What I am calling "Numbered Lists" refers to the lists that have styled numbers as shown [here](https://bytebucket.org/adblockplus/spec/raw/5eef1222584c3a04802b d523d293f0bb58a5b5e4/res/help-center/abp-help-article.jpg). This will be impleme nted as an ordered list `ol`, but I'm making the distinction here to differentia te that style from other ordered lists. 69 What I am calling "Numbered Lists" refers to the lists that have styled numbers as shown [here](https://bytebucket.org/adblockplus/spec/raw/5eef1222584c3a04802b d523d293f0bb58a5b5e4/res/help-center/abp-help-article.jpg). This will be impleme nted as an ordered list `ol`, but I'm making the distinction here to differentia te that style from other ordered lists.
70
71 "Underlined Lists" refers to the lists as shown in the Topic Group, Accordion Me nu, and Search Results.
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld