Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java

Issue 29465639: Issue 5309 - Subscriptions update causes ANR (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git
Patch Set: @sergz Created June 14, 2017, 2:57 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java
diff --git a/libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java b/libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java
index 6e90006e8daf1c86dcdb9d10f970bfbf7a3938f9..b577536c0b8ed5082225635c854dadc3037e094d 100644
--- a/libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java
+++ b/libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java
@@ -196,6 +196,16 @@ public final class FilterEngine implements Disposable
return getAcceptableAdsSubscriptionURL(this.ptr);
}
+ /**
+ * Schedules updating of a subscription corresponding to the passed URL.
+ * @param subscriptionUrl may contain query parameters, only the beginning of the string is used
+ * to find a corresponding subscription.
+ */
+ public void updateFiltersAsync(String subscriptionUrl)
anton 2017/06/15 05:51:53 i don't like the idea of having 'Subscription.upda
sergei 2017/06/16 11:12:08 When the request is intercepted there is no subscr
anton 2017/06/16 11:25:12 Acknowledged.
+ {
+ updateFiltersAsync(this.ptr, subscriptionUrl);
+ }
+
@Override
public void dispose()
{
@@ -276,5 +286,7 @@ public final class FilterEngine implements Disposable
private final static native String getAcceptableAdsSubscriptionURL(long ptr);
+ private final static native void updateFiltersAsync(long ptr, String subscriptionUrl);
+
private final static native void dtor(long ptr);
}

Powered by Google App Engine
This is Rietveld