Issue 5345 - Whitelist $elemhide and $generichide domains where possible

abp2blocklist.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 14 matching lines @@
 var blockerList = new ContentBlockerList();
 
 rl.on("line", line =>
 {
   if (/^\s*[^\[\s]/.test(line))
     blockerList.addFilter(Filter.fromText(Filter.normalize(line)));
 });
 
 rl.on("close", () =>
 {
-  console.log(JSON.stringify(blockerList.generateRules(), null, "\t"));
+  let rules = blockerList.generateRules();
+
+  // If the rule set is too huge, Node.js throws

[Manish Jethani, 2017/06/24 14:54:15]

This had to be done because of this change.

[kzar, 2017/07/07 11:40:13]

So if the exception is thrown then only half the JSON will be printed right? I
kinda wonder how that's useful if so.

[Manish Jethani, 2017/07/08 05:33:59]

If the exception is thrown the program crashes. This happens if the rule set is
too huge. Since we're printing one rule at a time, this is not an issue.

The exception is thrown in JSON.stringify, I've made it clear in the comment
now.

[kzar, 2017/07/10 12:33:07]

Acknowledged.

+  // "RangeError: Invalid string length". As a workaround, print each rule
+  // individually.
+  console.log("[");
+  if (rules.length > 0)
+  {
+    let stringifyRule = rule => JSON.stringify(rule, null, "\t");
+    for (let i = 0; i < rules.length - 1; i++)
+      console.log(stringifyRule(rules[i]) + ",");
+    console.log(stringifyRule(rules[rules.length - 1]));
+  }
+  console.log("]");
 });