Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: templates/default.tmpl

Issue 29474565: Issue 5350 - Setup Help Center Boilerplate (Closed)
Patch Set: Add website defaults Created June 27, 2017, 2:17 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« static/scss/base/_font.scss ('K') | « static/scss/main.scss ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: templates/default.tmpl
===================================================================
--- a/templates/default.tmpl
+++ b/templates/default.tmpl
@@ -1,33 +1,45 @@
-{#
- # This file is part of help.eyeo.com.
- # Copyright (C) 2017 Eyeo GmbH
- #
- # help.eyeo.com is free software: you can redistribute it and/or modify
- # it under the terms of the GNU General Public License as published by
- # the Free Software Foundation, either version 3 of the License, or
- # (at your option) any later version.
- #
- # help.eyeo.com is distributed in the hope that it will be useful,
- # but WITHOUT ANY WARRANTY; without even the implied warranty of
- # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- # GNU General Public License for more details.
- #
- # You should have received a copy of the GNU General Public License
- # along with acceptableads.org. If not, see <http://www.gnu.org/licenses/>.
- #}<!DOCTYPE html>
+<!DOCTYPE html>
+<!--
+ This file is part of help.eyeo.com.
+ Copyright (C) 2017 Eyeo GmbH
+
+ help.eyeo.com is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 3 of the License, or
+ (at your option) any later version.
+
+ help.eyeo.com is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with acceptableads.org. If not, see <http://www.gnu.org/licenses/>.
+-->
<html
lang="{{ locale }}"
juliandoucette 2017/07/03 15:37:55 Note: I'm probably going to include these html-att
ire 2017/07/04 09:33:17 Haha no I don't think you're going too far. In thi
dir="{{ "rtl" if config.has_option("rtl", locale) else "ltr" }}">
<head>
<meta charset="utf-8">
juliandoucette 2017/07/03 15:37:55 Like I mentioned in the last patchset, these are i
ire 2017/07/04 09:33:17 No problem. See my comment about swapping these ou
+ <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
+ <meta http-equiv="x-ua-compatible" content="ie=edge">
+
<title>{{ title | translate("page-title", "Meta page title") }}</title>
- <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
+
+ <!--[if IE 8]>
juliandoucette 2017/07/03 15:37:56 Like I mentioned in the vendor css, I think should
ire 2017/07/04 09:33:17 Acknowledged.
+ <script src="js/vendor/ie8.js"></script>
+ <![endif]-->
- <link rel="stylesheet" href="/css/main.css">
+ <link rel="stylesheet" href="css/main.css">
+
+ <!--[if lt IE 9]>
juliandoucette 2017/07/03 15:37:55 See comment above (ie8.js).
ire 2017/07/04 09:33:17 Acknowledged.
+ <script src="js/vendor/html5shiv.js"></script>
+ <script src="js/vendor/respond.min.js"></script>
+ <![endif]-->
{{ head | safe }}
juliandoucette 2017/07/03 15:37:55 I don't think {{ head | safe }} does anything with
ire 2017/07/04 09:33:17 Done. That's me not understanding how the cms work
</head>
<body>
{{ body | safe }}
juliandoucette 2017/07/03 15:37:55 I don't think you can extend the body in a child t
ire 2017/07/04 09:33:17 Done.
</body>
<html>
« static/scss/base/_font.scss ('K') | « static/scss/main.scss ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld