Noissue - Merge packages variable correctly of all hiera scopes in adblockplus module

modules/adblockplus/manifests/init.pp

 # == Class: adblockplus
 #
 # The adblockplus class and the associated adblockplus:: namespace are
 # used to integrate Puppet modules with each other, in order to assemble
 # the setups used by the Adblock Plus project.
 #
 # === Parameters:
 #
 # [*authority*]
 #   The authorative domain or zone associated with the current environment.
 #
 # [*hosts*]
 #   A hash of adblockplus::host $name => $parameter items to set up in this
 #   context, i.e. via Hiera.
 #
 # [*users*]
 #   A hash of adblockplus::user $name => $parameter items to set up in this
 #   context, i.e. via Hiera.
 #
 # [*packages*]
 #   An array of adblockplus::packages items to set up in this context,
-#   i.e. via Hiera.
+#   via Hiera, exclusively.
 #
 # === Examples:
 #
 #   class {'adblockplus':
 #     hosts => {
 #       'node1' => {
 #         # see adblockplus::host
 #       },
 #     },
 #     users => {
 #       'pinocchio' => {
 #         # see adblockplus::user
 #       },
 #     },
 #   }
 #
 class adblockplus (
   $authority = hiera('adblockplus::authority', 'adblockplus.org'),
   $hosts = hiera_hash('adblockplus::hosts', {}),
-  $packages = hiera_array('adblockplus::packages', []),
   $users = hiera_hash('adblockplus::users', {}),
 ) {
 
   include adblockplus::legacy
   include postfix
   include ssh
   include stdlib
 
   # See https://issues.adblockplus.org/ticket/3575#comment:2
   class {'logrotate':
@@ skipping 55 matching lines @@
       '/etc/ssh/ssh_host_rsa_key.pub':
         source => 'puppet:///modules/adblockplus/development_host_rsa_key.pub',
         mode => '0644',
     }
   }
 
   # Fix implicit package dependency Class['apt'] does not properly handle
   Exec['apt_update'] -> Package<|title != 'python-software-properties'|>
 
   # https://issues.adblockplus.org/ticket/3574#comment:19
+  $packages = hiera_array('adblockplus::packages', []),
   ensure_packages($packages)
 
   # https://projects.puppetlabs.com/issues/4145
   ensure_resource('file', '/etc/ssh/ssh_known_hosts', {
     ensure => 'present',
     mode => '0644',
   })
 
   # See modules/adblockplus/manifests/host.pp
   create_resources('adblockplus::host', $hosts)
 
   # See modules/adblockplus/manifests/user.pp
   create_resources('adblockplus::user', $users)
 }