Issue 5406 - Create Site Footer Component for Help Center

static/scss/components/_select.scss

+// This file is part of help.eyeo.com.
+// Copyright (C) 2017 Eyeo GmbH
+//
+// help.eyeo.com is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// help.eyeo.com is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
+
+// Custom Select Field
+
+.custom-select
+{
+  position: relative;
+}
+
+.custom-select-selected

[juliandoucette, 2017/08/22 14:33:42]

NIT: It seem strange to have a class that ends in "selected" always visible

[ire, 2017/09/04 20:28:07]

The "selected" refers to the fact that it is the currently selected option, and
there will always be a currently selected option in a select field (even if its
a blank option)

[juliandoucette, 2017/09/06 17:48:19]

Acknowledged. *embarrassed face* :D

[ire, 2017/09/08 09:53:32]

:P

+{
+  display: inline-block;
+  padding: 3px 10px;

[juliandoucette, 2017/08/22 14:33:42]

NIT: Padding should probably be in em

[ire, 2017/09/04 20:28:07]

Done.

+  border: 1px solid $gray-medium;

[juliandoucette, 2017/08/22 14:33:42]

NIT: Suggest: 2px border. I don't think this passes the width/contrast
accessibility ratio.

[ire, 2017/09/04 20:28:07]

Done.

+  border-radius: 4px;
+  color: $white;
+  background: transparent;
+  font-family: $primary-font;

[juliandoucette, 2017/08/22 14:33:42]

NIT: why bind this control to one font and size? (why not inherit these
properties)

[ire, 2017/09/04 20:28:06]

Done.

+  font-size: $medium-font;
+  cursor: pointer;
+}
+
+.custom-select-options
+{
+  position: absolute;
+  bottom: 120%;

[juliandoucette, 2017/08/22 14:33:42]

NIT: Could we use 100% + margin in em effectively instead?

[ire, 2017/09/04 20:28:07]

Great idea! Done.

+  left: 0;
+  padding: 10px;

[juliandoucette, 2017/08/22 14:33:42]

NIT: I think em makes more sense here?

[ire, 2017/09/04 20:28:06]

Done.

+  border: 1px solid $gray-medium;
+  border-radius: 4px;
+  box-shadow: 0 0 10px 0 rgba(0, 0, 0, 0.3);
+  color: $black;
+  background: $white;
+  list-style: none;
+
+  a
+  {
+    color: $black;
+  }
+}
+
+.custom-select-options[aria-hidden="true"]
+{
+  display: none;
+}
+
+[dir="rtl"]
+{
+  .custom-select-options
+  {
+    right: 0;
+    left: auto;
+    padding: 10px;
+  }
+}
+
+.no-js

[juliandoucette, 2017/08/22 14:33:42]

NIT: I suggest adding no-js styles below items like we do rtl styles

[ire, 2017/09/04 20:28:07]

In general I agree. In this case, there is actually no styling for the
particular selectors (besides .custom-select-options), so they would be placed
in the same position anyway. The only difference would be ungrouping the .no-js
styles (which could be what we want, I'm not sure on that). 

[juliandoucette, 2017/09/06 17:48:20]

There is for .custom-select-selected and .custom-select-options (which caused me
to notice).

[ire, 2017/09/08 09:53:32]

I meant in this particular block. But I've changed the order a bit.

+{
+  .custom-select-selected
+  {
+    display: none;
+  }
+
+  .custom-select-options
+  {
+    display: inline-block;
+    top: 0;
+    padding: 0;
+    border: 0;
+    color: inherit;
+    opacity: 1;
+    background: none;
+  }
+
+  .custom-select-options li
+  {
+    display: inline;
+  }
+
+  .custom-select-options li:not(:last-child):after
+  {
+    content: ",";
+  }
+
+  a
+  {
+    color: inherit;
+  }
+}