includes/layout/footer.tmpl - Issue 29488555: Issue 5406 - Create Site Footer Component for Help Center

Side by Side Diff: includes/layout/footer.tmpl

Issue 29488555: Issue 5406 - Create Site Footer Component for Help Center (Closed)

Patch Set: Rebased and updated Created Sept. 4, 2017, 8:27 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <footer id="site-footer" class="navbar">
	juliandoucette 2017/09/06 17:48:20 Note: (Added after the comments below) It looks li Note: (Added after the comments below) It looks like we should considering using a menubar / menu / menu button pattern as described here https://www.w3.org/TR/wai-aria-practices/#menu, https://www.w3.org/TR/wai-aria-practices/examples/menubar/menubar-1/menubar-1.... ire 2017/09/08 09:53:33 Good idea! Done. There are improvements I can mak Show quoted text On 2017/09/06 17:48:20, juliandoucette wrote: > Note: (Added after the comments below) It looks like we should considering using > a menubar / menu / menu button pattern as described here > https://www.w3.org/TR/wai-aria-practices/#menu, > https://www.w3.org/TR/wai-aria-practices/examples/menubar/menubar-1/menubar-1.... Good idea! Done. There are improvements I can make to this component to satisfy the keyboard support for a menu. I would like to make these changes in a separate issue though. juliandoucette 2017/09/08 17:02:52 Acknowledged. Show quoted text On 2017/09/08 09:53:33, ire wrote: > On 2017/09/06 17:48:20, juliandoucette wrote: > > Note: (Added after the comments below) It looks like we should considering > using > > a menubar / menu / menu button pattern as described here > > https://www.w3.org/TR/wai-aria-practices/#menu, > > > https://www.w3.org/TR/wai-aria-practices/examples/menubar/menubar-1/menubar-1.... > > Good idea! Done. > > There are improvements I can make to this component to satisfy the keyboard > support for a menu. I would like to make these changes in a separate issue > though. Acknowledged.
	2 <div class="navbar-wrapper row">

	3 <div class="column one-fourth">

	4 <div class="custom-select">

	5 <button class="custom-select-selected" aria-expanded="false" aria-contro ls="language-options">
	juliandoucette 2017/09/06 17:48:21 Is there a reason that you didn't add aria-haspopu Is there a reason that you didn't add aria-haspopup and/or aria-expanded? ire 2017/09/08 09:53:34 See comment above. Show quoted text On 2017/09/06 17:48:21, juliandoucette wrote: > Is there a reason that you didn't add aria-haspopup and/or aria-expanded? See comment above.
	6 {{config.get("langnames", locale)}}

	7 </button>

	8 <ul id="language-options" class="custom-select-options">
	juliandoucette 2017/09/06 17:48:21 Is there a reason that you didn't add aria-labelle Is there a reason that you didn't add aria-labelledby? ire 2017/09/08 09:53:34 See comment above. Show quoted text On 2017/09/06 17:48:21, juliandoucette wrote: > Is there a reason that you didn't add aria-labelledby? See comment above.
	9 {% for lang in available_locales %}
	juliandoucette 2017/09/06 17:48:20 NIT: These are locale codes not languages or langu NIT: These are locale codes not languages or language codes? ( <- that might be a stretch ) ire 2017/09/08 09:53:34 Not sure what you mean. Am I using the wrong varia Show quoted text On 2017/09/06 17:48:20, juliandoucette wrote: > NIT: These are locale codes not languages or language codes? ( <- that might be > a stretch ) Not sure what you mean. Am I using the wrong variable here? juliandoucette 2017/09/08 17:02:52 I was suggesting that you use a variable like "ava Show quoted text On 2017/09/08 09:53:34, ire wrote: > Not sure what you mean. Am I using the wrong variable here? I was suggesting that you use a variable like "available_locale" instead of "lang" because "locale" is more accurate than "language" in this case. (I was being too picky.) ire 2017/09/12 08:57:53 Ah I see. "available_locale" makes more sense, not Show quoted text On 2017/09/08 17:02:52, juliandoucette wrote: > On 2017/09/08 09:53:34, ire wrote: > > Not sure what you mean. Am I using the wrong variable here? > > I was suggesting that you use a variable like "available_locale" instead of > "lang" because "locale" is more accurate than "language" in this case. (I was > being too picky.) Ah I see. "available_locale" makes more sense, not too picky :) Done.
	10 <li>

	11 {{page\|linkify(lang)}}

	12 {{config.get("langnames", lang)}}
	juliandoucette 2017/09/06 17:48:21 NIT: You are spacing {{ }} inconsistently in this NIT: You are spacing {{ }} inconsistently in this file. I suggest always adding one space after opening and before closing. ire 2017/09/08 09:53:34 Done. Show quoted text On 2017/09/06 17:48:21, juliandoucette wrote: > NIT: You are spacing {{ }} inconsistently in this file. I suggest always adding > one space after opening and before closing. Done.
	13 </a>

	14 </li>

	15 {% endfor %}

	16 </ul>

	17 </div>

	18 </div>

	19 <div class="column three-fourths">

	20 <nav id="site-footer-nav">

	21 <ul>

	22 <li><a href="">{{ "Legal" \| translate("footer-nav-link-1", "Navigation link") }}</a></li>

	23 <li><a href="https://adblockplus.org/privacy">{{ "Privacy Policy" \| tr anslate("footer-nav-link-2", "Navigation link") }}</a></li>

	24 </ul>

	25 </nav>

	26 <small class="muted">

	27 {{ "<a href=\"https://adblockplus.org\">Adblock Plus</a> is a registered trademark of <a href=\"https://eyeo.com\">eyeo GmbH</a>" \| translate("footer-tr ademark-notice", "Paragraph") }}

	28 </small>

	29 </div>

	30 </div>

	31 </footer>

OLD	NEW

« no previous file with comments | « no previous file | settings.ini » ('j') | static/scss/base/_utilities.scss » ('J')