static/scss/content/_typography.scss - Issue 29488555: Issue 5406 - Create Site Footer Component for Help Center

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: static/scss/content/_typography.scss

Issue 29488555: Issue 5406 - Create Site Footer Component for Help Center (Closed)

Patch Set: Rebased and updated Created Sept. 4, 2017, 8:27 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // This file is part of help.eyeo.com.

	2 // Copyright (C) 2017 Eyeo GmbH

	3 //

	4 // help.eyeo.com is free software: you can redistribute it and/or modify

	5 // it under the terms of the GNU General Public License as published by

	6 // the Free Software Foundation, either version 3 of the License, or

	7 // (at your option) any later version.

	8 //

	9 // help.eyeo.com is distributed in the hope that it will be useful,

	10 // but WITHOUT ANY WARRANTY; without even the implied warranty of

	11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	12 // GNU General Public License for more details.

	13 //

	14 // You should have received a copy of the GNU General Public License

	15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.

	16

	17 // Links ////////////////////////////////////////////////////////////

	18

	19 a

	20 {

	21 color: inherit;
	juliandoucette 2017/09/06 17:48:21 I think that you are trying to override the defaul I think that you are trying to override the default link color because links outside of content areas are not accent colored. If that is the case then doesn't it make more sense to namespace website-default _content.scss styles and apply this style inside website-default _reset.scss? ire 2017/09/08 09:53:35 Yes that is what I was trying to do, and your sugg Show quoted text On 2017/09/06 17:48:21, juliandoucette wrote: > I think that you are trying to override the default link color because links > outside of content areas are not accent colored. If that is the case then > doesn't it make more sense to namespace website-default _content.scss styles and > apply this style inside website-default _reset.scss? Yes that is what I was trying to do, and your suggestion makes sense. I will change this when website-default updates have been made.
	22 }

OLD	NEW

« static/scss/components/_select.scss ('K') | « static/scss/components/_select.scss ('k') | static/scss/layout/_footer.scss » ('j') | static/scss/layout/_footer.scss » ('J')