includes/layout/footer.tmpl - Issue 29488555: Issue 5406 - Create Site Footer Component for Help Center

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: includes/layout/footer.tmpl

Issue 29488555: Issue 5406 - Create Site Footer Component for Help Center (Closed)

Patch Set: Use menu pattern on custom select, horizontal list utliity class, etc Created Sept. 8, 2017, 9:52 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <footer id="site-footer" class="navbar">

	2 <div class="navbar-wrapper row">

	3 <div id="site-footer-locales" class="column one-fourth">

	4 <div class="custom-select">

	5 <button class="custom-select-selected" aria-expanded="false" aria-haspop up="true">

	6 {{ config.get("langnames", locale) }}

	7 </button>

	8 <ul class="custom-select-options" aria-label="{{ "Select Language" \| tra nslate("language-options-label", "Label") }}" role="menu" tabindex="-1">

	9 {% for lang in available_locales %}

	10 <li role="none">
	juliandoucette 2017/09/08 17:02:53 Shouldn't this role be "presentation"? :/ Shouldn't this role be "presentation"? :/ ire 2017/09/12 08:57:55 According to the example, it should be "none" in o Show quoted text On 2017/09/08 17:02:53, juliandoucette wrote: > Shouldn't this role be "presentation"? :/ According to the example, it should be "none" in order to remove the implied "listitem" role. See this table https://www.w3.org/TR/wai-aria-practices/examples/menubar/menubar-1/menubar-1... juliandoucette 2017/09/12 11:41:12 Acknowledged. I looked into this further and forg Show quoted text On 2017/09/12 08:57:55, ire wrote: > On 2017/09/08 17:02:53, juliandoucette wrote: > > Shouldn't this role be "presentation"? :/ > > According to the example, it should be "none" in order to remove the implied > "listitem" role. > > See this table > https://www.w3.org/TR/wai-aria-practices/examples/menubar/menubar-1/menubar-1... Acknowledged. I looked into this further and forgot to rescind this comment.
	11 {{ page \| linkify(lang) }}

	12 {{ config.get("langnames", lang) }}

	13 </a>

	14 </li>

	15 {% endfor %}

	16 </ul>

	17 </div>

	18 </div>

	19 <div id="site-footer-nav" class="column three-fourths">
	juliandoucette 2017/09/08 17:02:53 This section is aligned left between phablet and t This section is aligned left between phablet and tablet sizes when JavaScript is disabled because of the absolute positioning of the custom select. This looks like a grid bug :/ juliandoucette 2017/09/08 17:02:54 The nav and small are not vertically aligned middl The nav and small are not vertically aligned middle with the language selector. ire 2017/09/12 08:57:54 I wasn't intended for it to. The content in both a Show quoted text On 2017/09/08 17:02:54, juliandoucette wrote: > The nav and small are not vertically aligned middle with the language selector. I wasn't intended for it to. The content in both are aligned top. When the screen is resized, the content here flows onto more than one line, and I wanted the language selector to remain aligned top. ire 2017/09/12 08:57:54 I wasn't able to replicate this, but the .custom-s Show quoted text On 2017/09/08 17:02:53, juliandoucette wrote: > This section is aligned left between phablet and tablet sizes when JavaScript is > disabled because of the absolute positioning of the custom select. This looks > like a grid bug :/ I wasn't able to replicate this, but the .custom-select-options shouldn't be absolutely positioned with no javascript, so I've changed that and hopefully the issue is fixed
	20 <nav>

	21 <ul class="horizontal-list">

	22 <li><a href="">{{ "Legal" \| translate("footer-nav-link-1", "Navigation link") }}</a></li>

	23 <li><a href="https://adblockplus.org/privacy">{{ "Privacy Policy" \| tr anslate("footer-nav-link-2", "Navigation link") }}</a></li>

	24 </ul>

	25 </nav>

	26 <small class="muted">
	juliandoucette 2017/09/08 17:02:54 "eyeo GmbH" breaks oddly between phablet and table "eyeo GmbH" breaks oddly between phablet and tablet sizes. ire 2017/09/12 08:57:54 Done. Show quoted text On 2017/09/08 17:02:54, juliandoucette wrote: > "eyeo GmbH" breaks oddly between phablet and tablet sizes. Done.
	27 {{ "<a href=\"https://adblockplus.org\">Adblock Plus</a> is a registered trademark of <a href=\"https://eyeo.com\">eyeo GmbH</a>" \| translate("footer-tr ademark-notice", "Paragraph") }}

	28 </small>

	29 </div>

	30 </div>

	31 </footer>

OLD	NEW

« no previous file with comments | « no previous file | settings.ini » ('j') | static/scss/components/_select.scss » ('J')