Issue 5406 - Create Site Footer Component for Help Center

static/scss/layout/_footer.scss

 // This file is part of help.eyeo.com.
 // Copyright (C) 2017 Eyeo GmbH
 //
 // help.eyeo.com is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // help.eyeo.com is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
 
 #site-footer
 {
   font-size: $small-font;

[juliandoucette, 2017/08/22 14:33:43]

I don't think this does anything after all other styles are considered.

[ire, 2017/09/04 20:28:08]

Which other styles? From my test, this makes a difference to the font size.

[juliandoucette, 2017/09/06 17:48:20]

I was mislead by the effect of font-size: 100%; sorry :D

[ire, 2017/09/08 09:53:33]

No worries :)

 }
 
-#site-footer .one-fourth

[juliandoucette, 2017/08/22 14:33:43]

I think it makes more sense to add margin (in em not px) to the custom-select;
not the row.

[ire, 2017/09/04 20:28:08]

The margin is more to separate the first row from the second. The margin should
be applied even if there was more content in that row than just the
custom-select

+#site-footer .column
 {
-  margin-bottom: 10px;
+  padding: 0px;
 
-  @media (min-width: $mobile-breakpoint)
+  @media (min-width: $phablet-breakpoint)
+  {
+    width: 50%;
+  }
+}
+
+#site-footer-locales
+{
+  margin-bottom: $sm;
+
+  @media (min-width: $phablet-breakpoint)
   {
     margin-bottom: 0;
   }
 }
 
-#site-footer .three-fourths
+#site-footer-nav
 {
-  @media (min-width: $mobile-breakpoint)
+  @media (min-width: $phablet-breakpoint)
   {
     text-align: right;
   }
 }
 
-#site-footer-nav
+[dir="rtl"] #site-footer-nav
+{
+  @media (min-width: $phablet-breakpoint)
+  {
+    text-align: left;
+  }
+}
+
+#site-footer-nav nav
 {
   @media (min-width: $tablet-breakpoint)
   {
     display: inline;
   }
 }
 
-#site-footer-nav ul
+#site-footer-nav nav li
 {
-  display: inline;
-  list-style: none;
-}
+  margin-right: $sm;
+  padding-right: $sm;
+  border-right: 1px solid $gray;
 
-#site-footer-nav li
-{
-  display: inline;
-
-  &:not(:last-child)

[juliandoucette, 2017/08/22 14:33:43]

not is not supported by IE

[ire, 2017/09/04 20:28:08]

Done.

+  &:last-child
   {
-    margin-right: 10px;
-    padding-right: 10px;
-    border-right: 1px solid $gray;
+    margin-right: 0px;
+    padding-right: 0px;
+    border-right: 0px;
   }
 
   @media (min-width: $tablet-breakpoint)
   {
     &:last-child

[juliandoucette, 2017/08/22 14:33:43]

last-child is not supported by IE

[ire, 2017/09/04 20:28:08]

:last-child is supported by IE 9+ (http://caniuse.com/#feat=css-sel3)

[juliandoucette, 2017/09/06 17:48:20]

I suggest that we support IE 8 by default or document that we don't support it
in an issue which we may later resolve or reject ( It's hard to have a strong
opinion in favour of supporting IE 8 :D ) ( because ABP currently supports IE 8
and so does our browserlistrc; currently ).

[ire, 2017/09/08 09:53:33]

The current browserlist for this site supports IE9+, which is why I thought we
weren't supporting IE 8. It seems like browser support is still somewhat
uncertain :/ 

     {
-      margin-right: 10px;
-      padding-right: 10px;
+      margin-right: $sm;
+      padding-right: $sm;
       border-right: 1px solid $gray;
     }
   }
 }
 
-[dir="rtl"]

[juliandoucette, 2017/08/22 14:33:43]

NIT: Please move rtl styles directly below ltr styles

[ire, 2017/09/04 20:28:08]

Done.

+#site-footer-nav a
 {
-  #site-footer .three-fourths
-  {
-    @media (min-width: $mobile-breakpoint)
-    {
-      text-align: left;
-    }
-  }
-
-  #site-footer-nav ul
-  {
-    padding: 0;
-  }
+  white-space: nowrap;
 }