Delta Between Two Patch Sets: includes/layout/footer.tmpl
Issue 29488555:
Issue 5406 - Create Site Footer Component for Help Center (Closed)
Left Patch Set: No-js fixes
Created Sept. 12, 2017, 8:57 a.m.
Right Patch Set: Remove langnames commit, use website-default breakpoint variables
Created Sept. 18, 2017, 3:09 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
static/js/main.js » ('j')
|
static/scss/layout/_grid.scss » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <footer id="site-footer" class="navbar"> | 1 <footer id="site-footer" class="navbar"> |
| 2 <div class="navbar-wrapper row"> | 2 <div class="navbar-wrapper row"> |
| 3 <div id="site-footer-locales" class="column one-fourth"> | 3 <div id="site-footer-locales" class="column one-fourth"> |
| 4 <div class="custom-select"> | 4 <div class="custom-select"> |
| 5 <button class="custom-select-selected" aria-expanded="false" aria-haspop up="true"> | 5 <button class="custom-select-selected" aria-expanded="false" aria-haspop up="true"> |
| 6 {{ config.get("langnames", locale) }} | 6 {{ config.get("langnames", locale) }} |
| 7 </button> | 7 </button> |
| 8 <ul class="custom-select-options" aria-label="{{ "Select Language" | tra nslate("language-options-label", "Label") }}" role="menu" tabindex="-1"> | 8 <ul class="custom-select-options" aria-label="{{ "Select Language" | tra nslate("language-options-label", "Label") }}" role="menu" tabindex="-1"> |
| 9 {% for available_locale in available_locales %} | 9 {% for available_locale in available_locales %} |
| 10 <li role="none"> | 10 <li role="none"> |
| 11 {{ page | linkify(available_locale) }} | 11 {{ page | linkify(available_locale) }}{{ config.get("langnames", ava ilable_locale) }}</a> |
|
juliandoucette
2017/09/12 11:41:12
NIT: This line break and indentation causes there
ire
2017/09/12 15:04:02
Done.
| |
| 12 {{ config.get("langnames", available_locale) }} | |
| 13 </a> | |
| 14 </li> | 12 </li> |
| 15 {% endfor %} | 13 {% endfor %} |
| 16 </ul> | 14 </ul> |
| 17 </div> | 15 </div> |
| 18 </div> | 16 </div> |
| 19 <div id="site-footer-nav" class="column three-fourths"> | 17 <div id="site-footer-nav" class="column three-fourths"> |
| 20 <nav> | 18 <nav> |
| 21 <ul class="horizontal-list"> | 19 <ul class="horizontal-list"> |
| 22 <li><a href="">{{ "Legal" | translate("footer-nav-link-1", "Navigation link") }}</a></li> | 20 <li><a href="">{{ "Legal" | translate("footer-nav-link-1", "Navigation link") }}</a></li> |
| 23 <li><a href="https://adblockplus.org/privacy">{{ "Privacy Policy" | tr anslate("footer-nav-link-2", "Navigation link") }}</a></li> | 21 <li><a href="https://adblockplus.org/privacy">{{ "Privacy Policy" | tr anslate("footer-nav-link-2", "Navigation link") }}</a></li> |
| 24 </ul> | 22 </ul> |
| 25 </nav> | 23 </nav> |
| 26 <small class="muted"> | 24 <small class="muted"> |
| 27 {{ "<a href=\"https://adblockplus.org\">Adblock Plus</a> is a registered trademark of <a href=\"https://eyeo.com\">eyeo GmbH</a>" | translate("footer-tr ademark-notice", "Paragraph") }} | 25 {{ "<a href=\"https://adblockplus.org\">Adblock Plus</a> is a registered trademark of <a href=\"https://eyeo.com\">eyeo GmbH</a>" | translate("footer-tr ademark-notice", "Paragraph") }} |
| 28 </small> | 26 </small> |
| 29 </div> | 27 </div> |
| 30 </div> | 28 </div> |
| 31 </footer> | 29 </footer> |
| LEFT | RIGHT |
« no previous file
|
static/js/main.js » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
