chrome/content/.eslintrc.json - Issue 29494577: Issue 5438 - Observer DOM changes to reapply filters.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: chrome/content/.eslintrc.json

Issue 29494577: Issue 5438 - Observer DOM changes to reapply filters. (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Created July 21, 2017, 7:53 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 {	1 {

2 "globals": {	2 "globals": {

	3 "MutationObserver": true,
	Wladimir Palant 2017/07/21 21:37:28 We have been here before. On Firefox this script d We have been here before. On Firefox this script doesn't run inside a window, so there will be no MutationObserver global. hub 2017/07/22 01:31:24 good to know. I guess we'll have to split things o Show quoted text On 2017/07/21 21:37:28, Wladimir Palant wrote: > We have been here before. On Firefox this script doesn't run inside a window, so > there will be no MutationObserver global. good to know. I guess we'll have to split things out. Wladimir Palant 2017/07/22 06:16:20 Why? Not assuming MutationObserver to be global an Show quoted text On 2017/07/22 01:31:24, hub wrote: > I guess we'll have to split things out. Why? Not assuming MutationObserver to be global and rather accessing it via window variable as I suggested should be sufficient. hub 2017/07/23 15:36:34 I had assumed that you meant it wasn't available a Show quoted text On 2017/07/22 06:16:20, Wladimir Palant wrote: > On 2017/07/22 01:31:24, hub wrote: > > I guess we'll have to split things out. > > Why? Not assuming MutationObserver to be global and rather accessing it via > window variable as I suggested should be sufficient. I had assumed that you meant it wasn't available at all. My bad.
3 "URL": true	4 "URL": true

4 }	5 }

5 }	6 }

OLD	NEW

« no previous file with comments | « no previous file | chrome/content/elemHideEmulation.js » ('j') | chrome/content/elemHideEmulation.js » ('J')