chrome/content/.eslintrc.json - Issue 29494577: Issue 5438 - Observer DOM changes to reapply filters.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: chrome/content/.eslintrc.json

Issue 29494577: Issue 5438 - Observer DOM changes to reapply filters. (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Improvements Created Aug. 2, 2017, 4 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
1 {	1 {

2 "globals": {	2 "globals": {

3 "URL": true	3 "URL": true,

	4 "Node": true
	Wladimir Palant 2017/08/08 11:01:00 That's once again a global which is only available That's once again a global which is only available in the window context, not going to be available in Firefox. Please use window.Node instead of assuming that you will have this. For reference, in Firefox we have only the globals imported at the top of https://hg.adblockplus.org/buildtools/file/tip/templates/bootstrap.js.tmpl in addition to ECMAScript builtins. hub 2017/08/09 20:16:57 Done. Show quoted text On 2017/08/08 11:01:00, Wladimir Palant wrote: > That's once again a global which is only available in the window context, not > going to be available in Firefox. Please use window.Node instead of assuming > that you will have this. > > For reference, in Firefox we have only the globals imported at the top of > https://hg.adblockplus.org/buildtools/file/tip/templates/bootstrap.js.tmpl in > addition to ECMAScript builtins. Done.
4 }	5 }

5 }	6 }

OLD	NEW

« no previous file with comments | « no previous file | chrome/content/elemHideEmulation.js » ('j') | chrome/content/elemHideEmulation.js » ('J')