Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/scss/content/_buttons.scss

Issue 29497585: Issue 4514 - Font readability on acceptableads.com (Closed) Base URL: https://hg.adblockplus.org/web.acceptableads.com
Left Patch Set: Created July 25, 2017, 1:34 p.m.
Right Patch Set: Increase spacing on fixed heights Created July 26, 2017, 8:43 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/scss/components/_cards.scss ('k') | static/scss/content/_typography.scss » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 // This file is part of acceptableads.org. 1 // This file is part of acceptableads.org.
2 // Copyright (C) 2016 Eyeo GmbH 2 // Copyright (C) 2016 Eyeo GmbH
3 // 3 //
4 // acceptableads.org is free software: you can redistribute it and/or modify 4 // acceptableads.org is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // acceptableads.org is distributed in the hope that it will be useful, 9 // acceptableads.org is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 13 matching lines...) Expand all
24 padding: 0 $sm; 24 padding: 0 $sm;
25 cursor: pointer; 25 cursor: pointer;
26 text-align: center; 26 text-align: center;
27 white-space: nowrap; 27 white-space: nowrap;
28 text-decoration: none; 28 text-decoration: none;
29 text-transform: uppercase; 29 text-transform: uppercase;
30 border: 1px solid; 30 border: 1px solid;
31 border-radius: 0px !important; 31 border-radius: 0px !important;
32 font-size: $font-size-md; 32 font-size: $font-size-md;
33 font-weight: 700; 33 font-weight: 700;
34 line-height: $md + 10px; 34 line-height: 42px;
ire 2017/07/25 13:36:22 I'm not sure if it's better to represent this numb
juliandoucette 2017/07/25 15:29:59 I think 42px is better.
ire 2017/07/26 08:44:22 Done.
35 height: 44px; 35 height: 44px;
36 } 36 }
37 37
38 @media(max-width: $mobile-breakpoint) 38 @media(max-width: $mobile-breakpoint)
39 { 39 {
40 %buttons 40 %buttons
41 { 41 {
42 display: block; 42 display: block;
43 float: none; 43 float: none;
44 margin: $sm 0; 44 margin: $sm 0;
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 margin-top: $md; 136 margin-top: $md;
137 margin-bottom: $md; 137 margin-bottom: $md;
138 } 138 }
139 139
140 @media (min-width: $tablet-breakpoint) 140 @media (min-width: $tablet-breakpoint)
141 { 141 {
142 margin-top: $lg; 142 margin-top: $lg;
143 margin-bottom: $lg; 143 margin-bottom: $lg;
144 } 144 }
145 } 145 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld