Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/JsError.cpp

Issue 29497616: Noissue - move anonymous namespace from header to cpp file (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created July 25, 2017, 2:53 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/JsError.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 #include "JsError.h" 18 #include "JsError.h"
19 19
20 namespace
21 {
22 std::string ExceptionToString(const v8::Handle<v8::Value>& exception,
23 const v8::Handle<v8::Message>& message)
24 {
25 std::stringstream error;
26 error << *v8::String::Utf8Value(exception);
27 if (!message.IsEmpty())
28 {
29 error << " at ";
30 error << *v8::String::Utf8Value(message->GetScriptResourceName());
31 error << ":";
32 error << message->GetLineNumber();
33 }
34 return error.str();
35 }
36 }
37
20 AdblockPlus::JsError::JsError(const v8::Handle<v8::Value>& exception, 38 AdblockPlus::JsError::JsError(const v8::Handle<v8::Value>& exception,
21 const v8::Handle<v8::Message>& message) 39 const v8::Handle<v8::Message>& message)
22 : std::runtime_error(ExceptionToString(exception, message)) 40 : std::runtime_error(ExceptionToString(exception, message))
23 { 41 {
24 } 42 }
OLDNEW
« no previous file with comments | « src/JsError.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld