Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/JsError.h

Issue 29497616: Noissue - move anonymous namespace from header to cpp file (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created July 25, 2017, 2:53 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/JsError.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/JsError.h
diff --git a/src/JsError.h b/src/JsError.h
index 30aecc0014c7588ea71bf9e9f1422892cf535f38..92b4a02f76ce125514f70f34b6bf90d4d905bd83 100644
--- a/src/JsError.h
+++ b/src/JsError.h
@@ -22,24 +22,6 @@
#include <stdexcept>
#include <v8.h>
-namespace
-{
- std::string ExceptionToString(const v8::Handle<v8::Value>& exception,
- const v8::Handle<v8::Message>& message)
- {
- std::stringstream error;
- error << *v8::String::Utf8Value(exception);
- if (!message.IsEmpty())
- {
- error << " at ";
- error << *v8::String::Utf8Value(message->GetScriptResourceName());
- error << ":";
- error << message->GetLineNumber();
- }
- return error.str();
- }
-}
-
namespace AdblockPlus
{
class JsError : public std::runtime_error
« no previous file with comments | « no previous file | src/JsError.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld