Issue 5459 - Add support to show a notification based on the number of ads blocked

lib/notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 286 matching lines @@
               checkTarget(target, "platform", platform, platformVersion))
           {
             match = true;
             break;
           }
         }
         if (!match)
           continue;
       }
 
+      if (typeof notification.blocked_total_min == 'number' &&
+          (typeof Prefs.blocked_total != 'number' ||
+          notification.blocked_total_min > Prefs.blocked_total))
+        continue

[Wladimir Palant, 2017/08/15 10:31:21]

Nit: please run ESLint. There should be a semicolon at the end of this
statement. Also, we usually require brackets around the body even if it is the
condition that is spanning multiple lines - ESLint cannot flag that. Yes, I am
aware that this rule already isn't being followed for the block above already.

[wspee, 2017/08/21 15:18:21]

Of course, sorry forgot to use ESLint.

+
+      if (typeof notification.blocked_total_max == 'number' &&
+          (typeof Prefs.blocked_total != 'number' ||
+          notification.blocked_total_max < Prefs.blocked_total))
+        continue

[Wladimir Palant, 2017/08/15 10:31:21]

We should use camelCase for consistency. Also, we should expect structured data,
something like:

  blockedTotal: {min: 0, max: 4000}

I just discussed this with Felix, and the conclusion is that this condition
belongs into the targets array, it shouldn't be there on its own.

[wspee, 2017/08/21 15:18:21]

I implemented the syntax from the issue (#5457), then it's also consistent with
extensionVersion, etc..

+
       if (!notificationToShow ||
           getNumericalSeverity(notification) >
             getNumericalSeverity(notificationToShow))
         notificationToShow = notification;
     }
 
     return notificationToShow;
   },
 
   /**
@@ skipping 149 matching lines @@
     else if (index != -1 && forceValue !== true)
       categories.splice(index, 1);
 
     // HACK: JSON values aren't saved unless they are assigned a
     // different object.
     Prefs.notifications_ignoredcategories =
       JSON.parse(JSON.stringify(categories));
   }
 };
 Notification.init();