test/notification.js - Issue 29501607: Issue 5459 - Add support to show a notification based on the number of ads blocked

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: test/notification.js

Issue 29501607: Issue 5459 - Add support to show a notification based on the number of ads blocked (Closed)

Patch Set: Addressed review comments Created Aug. 23, 2017, 10:10 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: test/notification.js

diff --git a/test/notification.js b/test/notification.js

index 4a5bc61d1baf99953c245d4441cb02c09944d909..1c56580889d8bfc41adb106c3609f1c6b56d3e2d 100644

--- a/test/notification.js

+++ b/test/notification.js

@@ -174,7 +174,15 @@ for (let [propName, value, result] of [

["platformMaxVersion", "12.0", true],

["platformMaxVersion", "12", true],

["platformMaxVersion", "13", true],

- ["platformMaxVersion", "11", false]

+ ["platformMaxVersion", "11", false],

+ ["blockedTotalMin", "11", false],

+ ["blockedTotalMin", "10", true],

+ ["blockedTotalMax", "10", true],

+ ["blockedTotalMax", "1", false],

+ ["locales", ["en-US"], true],

+ ["locales", ["en-US", "de-DE"], true],

+ ["locales", ["de-DE"], false],

+ ["locales", ["en-GB", "de-DE"], false]

])

{

exports.testTargetSelection[`${propName}=${value}`] = function(test)

@@ -213,7 +221,8 @@ for (let [[propName1, value1, result1], [propName2, value2, result2]] of pairs([

["platform", "chromium", true],

["platform", "gecko", false],

["platformMinVersion", "12", true],

- ["platformMinVersion", "13", false]

+ ["platformMinVersion", "13", false],

+ ["unkown", "unknown", false]

]))

{

exports.testMultipleTargets[`${propName1}=${value1},${propName2}=${value2}`] = function(test)