Issue 5482 - Sidebar and about ABP dialog

locale/en-US/new-options.json

Index: locale/en-US/new-options.json
===================================================================
--- a/locale/en-US/new-options.json
+++ b/locale/en-US/new-options.json
@@ -3,13 +3,13 @@
     "description": "Options page title",
     "message": "Adblock Plus Options"
   },
-  "options_page_header_1": {
+  "options_page_title_1": {
     "description": "Page title in navigation sidebar",

[juliandoucette, 2017/08/21 14:10:33]

NIT: These are headings not titles. IDK if it makes a difference to translators.

[saroyanm, 2017/08/21 15:20:21]

I don't think that title is misleading here, but I agree that this shouldn't be
translated.

[juliandoucette, 2017/08/21 16:07:23]

I don't know what you mean by "this shouldn't be translated".

[saroyanm, 2017/08/21 16:46:09]

This translation string is redundant: "Adblock <strong>Plus</strong>" shouldn't
be translated.

[saroyanm, 2017/08/21 17:02:55]

BTW I initially thought that you were referencing to the ID, but i agree that
heading would made more sense here.

[juliandoucette, 2017/08/22 10:10:43]

Acknowledged.

[saroyanm, 2017/08/23 13:35:44]

Done.

-    "message": "Options"
+    "message": "Adblock <strong>Plus</strong>"
   },
-  "options_page_header_2": {
-    "description": "Name of extension in navigation sidebar",
-    "message": "Adblock <strong>Plus</strong>"
+  "options_page_title_2": {
+    "description": "Page title in navigation sidebar",
+    "message": "Settings"
   },
   "options_tab_general": {
     "description": "Sidebar tab label",
@@ -27,17 +27,13 @@
     "description": "Sidebar tab label",
     "message": "Help"
   },
-  "options_version": {
-    "description": "Version label in navigation sidebar",
-    "message": "Version"
+  "options_footer_contribute": {
+    "description": "Sidebar button label",
+    "message": "Contribute"
   },
-  "options_tab_share": {
-    "description": "Share button in navigation sidebar",
-    "message": "Share"
-  },
-  "options_tab_contribute": {
-    "description": "Button in navigation sidebar to support Adblock Plus",
-    "message": "Support us"
+  "options_footer_about": {
+    "description": "Sidebar button label",
+    "message": "About Adblock Plus"
   },
   "options_control_remove_title": {
     "description": "Title of remove controls",
@@ -367,6 +363,24 @@
     "description": "Social media section description in Help tab",
     "message": "If there are major problems with Adblock Plus which affects all of our users, we tell you in our social media channels."
   },
+  "options_dialog_about_title": {
+    "description": "Title of 'about Adblock Plus' modal dialog ",
+    "message": "About Adblock Plus"
+  },
+  "options_dialog_about_version": {
+    "description": "Version information in 'about Adblock Plus' modal dialog ",
+    "message": "Version number $version$",
+    "placeholders": {
+      "version": {
+        "content": "$1",
+        "example": "2.6.7"
+      }
+    }
+  },
+  "options_dialog_about_copyright": {
+    "description": "Copyright information in 'about Adblock Plus' modal dialog ",
+    "message": "Copyright © 2017 eyeo GmbH. Adblock Plus is a registered ® trademark of eyeo GmbH."
+  },
   "options_dialog_predefined_confirm": {
     "description": "Confirming to add a predefined subscription when asked in a dialog",
     "message": "Yes, use this filter list"