Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: scss/forms/_basic.scss

Issue 29510560: Issue 4633 - Default form styles (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Patch Set: Addressed NITs Created Aug. 11, 2017, 3:23 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*!
2 * This file is part of website-defaults
3 * Copyright (C) 2016-2017 eyeo GmbH
4 *
5 * website-defaults is free software: you can redistribute it and/or
6 * modify it under the terms of the GNU General Public License as published by
7 * the Free Software Foundation, either version 3 of the License, or
8 * (at your option) any later version.
9 *
10 * website-defaults is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License
16 * along with website-defaults. If not, see <http://www.gnu.org/licenses/>.
17 */
18
19 /*******************************************************************************
20 * Basic forms fields
21 *******************************************************************************
22 * 1. Reset
23 ******************************************************************************/
24
25 /* 1. Reset
26 ******************************************************************************/
27
28 input,
29 optgroup,
30 select,
31 textarea
32 {
33 box-sizing: border-box;
34 margin: 0px;
juliandoucette 2017/08/24 12:35:24 NIT: We should mention that this effects Firefox a
ire 2017/09/13 07:59:57 Done.
35 font: inherit;
36 }
37
38 /**
39 * Show the overflow in IE and Edge
40 */
41
42 input
43 {
44 overflow: visible;
45 }
46
47 /**
48 * Remove the inheritance of text transform in Edge, Firefox, and IE.
49 */
50
51 select
52 {
53 text-transform: none;
54 }
55
56 fieldset,
juliandoucette 2017/08/24 12:35:24 NIT: We should mention that the rest of these styl
57 legend
58 {
59 display: block;
60 margin: 0px;
61 padding: 0px;
juliandoucette 2017/08/24 12:35:24 NIT: We should mention that this is correcting Fir
ire 2017/09/13 07:59:57 No longer relevant with update
62 border: 0px;
63 }
64
65 textarea
66 {
67 overflow: auto;
juliandoucette 2017/08/24 12:35:24 NIT: I think we should mention that this is removi
ire 2017/09/13 07:59:57 Done.
68 }
69
70 [type="checkbox"],
71 [type="radio"]
72 {
73 padding: 0px;
juliandoucette 2017/08/24 12:35:23 NIT: I think we should mention that we are removin
ire 2017/09/13 07:59:57 Done.
74 }
OLDNEW

Powered by Google App Engine
This is Rietveld