Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: scss/forms/_buttons.scss

Issue 29510560: Issue 4633 - Default form styles (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Left Patch Set: Separate forms into basic, advanced, and buttons Created Aug. 10, 2017, 11:44 a.m.
Right Patch Set: Addressed NITs Created Sept. 19, 2017, 8:07 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « scss/forms/_basic.scss ('k') | scss/main.scss » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /*! 1 /*!
2 * This file is part of website-defaults 2 * This file is part of website-defaults
3 * Copyright (C) 2016-2017 eyeo GmbH 3 * Copyright (C) 2016-2017 eyeo GmbH
4 * 4 *
5 * website-defaults is free software: you can redistribute it and/or 5 * website-defaults is free software: you can redistribute it and/or
6 * modify it under the terms of the GNU General Public License as published by 6 * modify it under the terms of the GNU General Public License as published by
7 * the Free Software Foundation, either version 3 of the License, or 7 * the Free Software Foundation, either version 3 of the License, or
8 * (at your option) any later version. 8 * (at your option) any later version.
9 * 9 *
10 * website-defaults is distributed in the hope that it will be useful, 10 * website-defaults is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details. 13 * GNU General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU General Public License 15 * You should have received a copy of the GNU General Public License
16 * along with website-defaults. If not, see <http://www.gnu.org/licenses/>. 16 * along with website-defaults. If not, see <http://www.gnu.org/licenses/>.
17 */ 17 */
18 18
19 /******************************************************************************* 19 /*******************************************************************************
20 * Buttons 20 * Buttons
21 ******************************************************************************* 21 *******************************************************************************
22 * 1. Reset 22 * 1. Reset
23 ******************************************************************************/ 23 ******************************************************************************/
24 24
25 /* 1. Reset 25 /* 1. Reset
26 ******************************************************************************/ 26 ******************************************************************************/
27 27
28 button 28 button
juliandoucette 2017/08/10 17:10:07 Note: I think we may want to share visual (not res
ire 2017/08/11 15:25:15 Okay, noted.
29 { 29 {
30 box-sizing: border-box;
31 margin: 0px; 30 margin: 0px;
32 font: inherit; 31 font: inherit;
33 32
34 /* Show the overflow in IE and Edge */ 33 /* Show the overflow in IE and Edge */
35 overflow: visible; 34 overflow: visible;
36 35
37 /* Remove the inheritance of text transform in Edge, Firefox, and IE. */ 36 /* Remove the inheritance of text transform in Edge, Firefox, and IE. */
38 text-transform: none; 37 text-transform: none;
39 } 38 }
40 39
41 /** 40 /**
42 * 1. Prevent a WebKit bug where (2) destroys native `audio` and `video` 41 * 1. Prevent a WebKit bug where (2) destroys native `audio` and `video`
43 * controls in Android 4. 42 * controls in Android 4.
44 * 2. Correct the inability to style clickable types in iOS and Safari. 43 * 2. Correct the inability to style clickable types in iOS and Safari.
45 */ 44 */
46 45
47 button, 46 button,
48 html [type="button"], 47 html [type="button"],
49 [type="reset"], 48 [type="reset"],
50 [type="submit"] 49 [type="submit"]
51 { 50 {
52 -webkit-appearance: button; 51 -webkit-appearance: button;
53 } 52 }
54 53
55 /** 54 /* Remove the inner border and padding in Firefox. */
56 * Remove the inner border and padding in Firefox.
57 */
58 55
59 button::-moz-focus-inner, 56 button::-moz-focus-inner,
60 [type="button"]::-moz-focus-inner, 57 [type="button"]::-moz-focus-inner,
61 [type="reset"]::-moz-focus-inner, 58 [type="reset"]::-moz-focus-inner,
62 [type="submit"]::-moz-focus-inner 59 [type="submit"]::-moz-focus-inner
63 { 60 {
64 padding: 0px; 61 padding: 0px;
65 border-style: none; 62 border-style: none;
66 } 63 }
67 64
68 /** 65 /* Restore the focus styles unset by the previous rule. */
69 * Restore the focus styles unset by the previous rule.
70 */
71 66
72 button:-moz-focusring, 67 button:-moz-focusring,
73 [type="button"]:-moz-focusring, 68 [type="button"]:-moz-focusring,
74 [type="reset"]:-moz-focusring, 69 [type="reset"]:-moz-focusring,
75 [type="submit"]:-moz-focusring 70 [type="submit"]:-moz-focusring
76 { 71 {
77 outline: 1px dotted ButtonText; 72 outline: 1px dotted ButtonText;
78 } 73 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld