Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: Makefile

Issue 29511621: Noissue - fix the value of gyp -Gandroid_ndk_version parameter in accordance to the used Android NDK (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created Aug. 10, 2017, 1:43 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Makefile
diff --git a/Makefile b/Makefile
index 41741fe9b94ee29203c34e5b4097b05b568d6825..a1fb3a052cb0b75d2efdcea8b3fbda5599d5c854 100644
--- a/Makefile
+++ b/Makefile
@@ -124,7 +124,7 @@ build-v8-android: v8_android_multi_${HOST_OS}_${ANDROID_ARCH}
android_multi: ${BUILD_V8} ensure_dependencies
GYP_DEFINES="${GYP_PARAMETERS} ${ABP_GYP_PARAMETERS}" \
- python ./make_gyp_wrapper.py --depth=. -f make-android -Ilibadblockplus.gypi --generator-output=build -Gandroid_ndk_version=r9 libadblockplus.gyp
+ python ./make_gyp_wrapper.py --depth=. -f make-android -Ilibadblockplus.gypi --generator-output=build -Gandroid_ndk_version=12b libadblockplus.gyp
anton 2017/08/10 13:47:10 for some [unknown] reason usually it's written wit
sergei 2017/08/10 13:51:06 Done.
$(ANDROID_NDK_ROOT)/ndk-build -C build installed_modules \
BUILDTYPE=Release \
APP_ABI=$(ANDROID_ABI) \
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld