Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: includes/index.tmpl

Issue 29511696: Issue 5447 - Add missing essential meta data to adblockplus.org (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Created Aug. 10, 2017, 9:21 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « filters/to_og_locale.py ('k') | pages/acceptable-ads.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: includes/index.tmpl
===================================================================
--- a/includes/index.tmpl
+++ b/includes/index.tmpl
@@ -21,22 +21,19 @@
<head>
<link class="cssfx" href="/css/index.css" rel="stylesheet">
<link class="cssfx" href="/css/index-desktop.css" media="(min-width: 1000px)" rel="stylesheet">
<link href="/css/index-mobile.css" media="(max-width: 1000px)" rel="stylesheet">
<link href="https://adblockplus.org/" rel="canonical">
<link href="https://chrome.google.com/webstore/detail/cfhdojbkjhnklbpkdaibdccddilifddb" rel="chrome-webstore-item">
-<meta content="product" property="og:type">
+<meta content="website" property="og:type">
juliandoucette 2017/08/10 21:32:43 Because there is no og:type "product"?
Thomas Greiner 2017/08/11 13:15:41 Pretty much but I don't fully remember anymore. L
juliandoucette 2017/08/11 20:26:58 Acknowledged. On second thought, I think that thi
<meta content="https://adblockplus.org/img/adblockplus_promo.png" property="og:image">
-<meta content="https://adblockplus.org/" property="og:url">
juliandoucette 2017/08/10 21:32:42 Because og:url is in the default template now.
Thomas Greiner 2017/08/11 13:15:41 From what I see in the code, this would mean that
juliandoucette 2017/08/11 20:26:58 That would be true if: - I set an og:url that incl
Thomas Greiner 2017/08/14 11:20:53 You're right… seems like that's hardcoded in there
juliandoucette 2017/08/15 17:14:26 I didn't account for these. Good catch. Big oversi
Thomas Greiner 2017/08/17 12:27:35 Great, thanks!
-<meta content="{{"Adblock Plus - Surf the web without annoying ads!"|translate("s1")}}" name="title">
<meta content="{{"<fix>Adblock Plus</fix> is the most popular ad blocker available for <fix>Firefox</fix>, <fix>Chrome</fix>, <fix>Opera</fix>, <fix>Safari</fix>, <fix>Android</fix> and <fix>Internet Explorer</fix>. Block all annoying ads all over the web: remove video ads on <fix>YouTube</fix>, block <fix>Facebook</fix> ads, get rid of pop-ups and much more. On <fix>Google Chrome</fix>, <fix>Adblock Plus</fix> is one of the fastest growing extensions ever. <fix>Adblock Plus</fix> is used on over <fix>100</fix> million devices. Download online for free now!"|translate("s2")}}" name="description">
juliandoucette 2017/08/10 21:32:42 I didn't remove this because it's string ID doesn'
-<meta content="{{"Adblock Plus - Surf the web without annoying ads!"|translate("s1")}}" property="og:title">
juliandoucette 2017/08/10 21:32:43 Because title and og:title are defined in the defa
<meta content="{{"<fix>Adblock Plus</fix> is the most popular ad blocker available for <fix>Firefox</fix>, <fix>Chrome</fix>, <fix>Opera</fix>, <fix>Safari</fix>, <fix>Android</fix> and <fix>Internet Explorer</fix>. Block all annoying ads all over the web: remove video ads on <fix>YouTube</fix>, block <fix>Facebook</fix> ads, get rid of pop-ups and much more. On <fix>Google Chrome</fix>, <fix>Adblock Plus</fix> is one of the fastest growing extensions ever. <fix>Adblock Plus</fix> is used on over <fix>100</fix> million devices. Download online for free now!"|translate("s2")}}" property="og:description">
</head>
<div id="abb-banner" class="notice">
<h2>{{"Want to block ads on your smartphone or tablet?"|translate("abb-banner-headline")}}</h2>
<img src="/img/abb-promo-image.png" alt="{{"Adblock Browser promotional image"|translate("abb-promotion-alt")}}" />
<a id="abb-android-download" href="https://adblockplus.org/redirect?link=adblock_browser_android_store">{{"Download Adblock Browser"|translate("abb-banner-button-text")}}</a>
<a id="abb-ios-download" href="https://adblockplus.org/redirect?link=adblock_browser_ios_store">{{"Download Adblock Browser"|translate("abb-banner-button-text")}}</a>
« no previous file with comments | « filters/to_og_locale.py ('k') | pages/acceptable-ads.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld