includes/contact.html - Issue 29519587: Issue 5534 - Create Contact Section for help.eyeo.com

Delta Between Two Patch Sets: includes/contact.html

Issue 29519587: Issue 5534 - Create Contact Section for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com

Left Patch Set: Created Aug. 18, 2017, 12:30 p.m.

Right Patch Set: Addressed final NITs Created Oct. 10, 2017, 6:33 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <section class="section-accent">	1 <aside id="contact" class="section-accent">

2 <div class="wrapper-sm">	2 <div class="container tablet-width">

3	3

4 <h2 class="h2 ta-center underlined">	4 <h2 class="h2 ta-center underlined">

5 {{contact[heading] Still looking for help?}}	5 {{contact-heading[heading] Still looking for help?}}
juliandoucette 2017/08/30 11:33:06 NIT/Suggest: ID contact-heading (I know... DRY but NIT/Suggest: ID contact-heading (I know... DRY but this ID is a little misleading?) ire 2017/09/25 08:47:35 Done. Show quoted text On 2017/08/30 11:33:06, juliandoucette wrote: > NIT/Suggest: ID contact-heading (I know... DRY but this ID is a little > misleading?) Done.
6 </h2>	6 </h2>

7	7

8 <div class="row">	8 <div class="row">

9 <section class="column one-half section">	9 <section class="column one-half section">
juliandoucette 2017/08/30 11:33:06 Note: I think we should be consistent about whethe Note: I think we should be consistent about whether we add .section before/after/inside rows and columns (I'm not saying that the way you did it here is wrong, I'm just thinking out loud. Feedback is welcome.) ire 2017/09/25 08:47:35 I think it depends on where we want the spacing. I Show quoted text On 2017/08/30 11:33:06, juliandoucette wrote: > Note: I think we should be consistent about whether we add .section > before/after/inside rows and columns > > (I'm not saying that the way you did it here is wrong, I'm just thinking out > loud. Feedback is welcome.) I think it depends on where we want the spacing. I don't know that we can have a rule that applies in all cases.
10 <header class="underlined">	10 <header class="underlined">

11 <h3 class="h4">	11 <h3 class="h4">

12 {{contact-social[heading] Get in touch}}	12 {{contact-social[heading] Get in touch}}

13 </h3>	13 </h3>

14 <p>	14 <p>

15 {{contact-social-description[paragraph] Drop us a line on Twitter or Facebook and get your question answered ASAP.}}	15 {{contact-social-description[paragraph] Drop us a line on Twitter or Facebook and get your question answered ASAP.}}

16 </p>	16 </p>

17 </header>	17 </header>

18 <a href="https://www.facebook.com/adblockplus">	18 <ul class="horizontal-list">

19 <img class="heading-icon" src="/img/png/logo-facebook.png" srcset="/im g/svg/logo-facebook.svg 2x" alt="">	19 <li>
ire 2017/08/18 12:34:30 I left a null alt attribute here since the text wi I left a null alt attribute here since the text will have essentially the same content juliandoucette 2017/08/30 11:33:06 NIT/Suggest: Describe the logo. It's a "rounded sq Show quoted text On 2017/08/18 12:34:30, ire wrote: > I left a null alt attribute here since the text will have essentially the same > content NIT/Suggest: Describe the logo. It's a "rounded square facebook hieroglyph". Blind people appreciate these details (in my experience working on a website for a group of blind people). Even when they are not functional. This is based on subjective experience; of course. We may be able to find contradictory evidence and/or philosophy. ire 2017/09/25 08:47:35 Done. I haven't heard any evidence on the contrary Show quoted text On 2017/08/30 11:33:06, juliandoucette wrote: > On 2017/08/18 12:34:30, ire wrote: > > I left a null alt attribute here since the text will have essentially the same > > content > > NIT/Suggest: Describe the logo. It's a "rounded square facebook hieroglyph". > Blind people appreciate these details (in my experience working on a website for > a group of blind people). Even when they are not functional. This is based on > subjective experience; of course. We may be able to find contradictory evidence > and/or philosophy. Done. I haven't heard any evidence on the contrary, and your suggestion sounds helpful.
20 Facebook	20 <a href="https://www.facebook.com/adblockplus">
ire 2017/08/18 12:34:30 Do we translate this? Do we translate this? juliandoucette 2017/08/30 11:33:06 Good question. I don't think it matters. The only Show quoted text On 2017/08/18 12:34:30, ire wrote: > Do we translate this? Good question. I don't think it matters. The only thing that matters is whether we are consistent about translating things like it or not. We could translate it by default and rely on the CMS to <fix> it by whitelist. Or we could not translate it. I think it requires less thinking to translate everything. ire 2017/09/25 08:47:35 I agree with you that translating everything makes Show quoted text On 2017/08/30 11:33:06, juliandoucette wrote: > On 2017/08/18 12:34:30, ire wrote: > > Do we translate this? > > Good question. I don't think it matters. The only thing that matters is whether > we are consistent about translating things like it or not. We could translate it > by default and rely on the CMS to <fix> it by whitelist. Or we could not > translate it. I think it requires less thinking to translate everything. I agree with you that translating everything makes sense. Done.
21 </a>	21 <img class="heading-icon" src="/img/png/logo-facebook.png" srcset= "/img/svg/logo-facebook.svg 2x"

22 <a href="https://twitter.com/AdblockPlus">	22 alt="{{facebook-logo[Image alt text] Rounded blue square Face book glyph}}">

23 <img class="heading-icon" src="/img/png/logo-twitter.png" srcset="/img /svg/logo-twitter.svg 2x" alt="">	23 {{facebook[Brand name] Facebook}}

24 Twitter	24 </a>

25 </a>	25 </li>

26 <a href="mailto:support@adblockplus.org">	26 <li>

27 <img class="heading-icon" src="/img/png/email-icon.png" srcset="/img/s vg/email-icon.svg 2x" alt="">	27 <a href="https://twitter.com/AdblockPlus">

28 Email	28 <img class="heading-icon" src="/img/png/logo-twitter.png" srcset=" /img/svg/logo-twitter.svg 2x"

29 </a>	29 alt="{{ftwitter-logo[Image alt text] Blue Twitter glyph}}">

	30 {{twitter[Brand name] Twitter}}

	31 </a>

	32 </li>

	33 <li>

	34 <a href="mailto:support@adblockplus.org">

	35 <img class="heading-icon" src="/img/png/email-icon.png" srcset="/i mg/svg/email-icon.svg 2x"

	36 alt="{{email-icon[Image alt text] Blue envelope}}">

	37 {{email[Link text] Email}}

	38 </a>

	39 </li>

	40 </ul>

30 </section>	41 </section>

31

32 <section class="column one-half section">	42 <section class="column one-half section">

33 <header class="underlined">	43 <header class="underlined">

34 <h3 class="h4">	44 <h3 class="h4">

35 {{contact-developer[heading] Looking for developer support?}}	45 {{contact-developer[heading] Looking for developer support?}}

36 </h3>	46 </h3>

37 <p>	47 <p>

38 {{contact-developer-description[paragraph] Find source code, release notes, advanced documentation and more.}}	48 {{contact-developer-description[paragraph] Find source code, release notes, advanced documentation and more.}}

39 </p>	49 </p>

40 </header>	50 </header>

41 <a href="https://adblockplus.org/forum">	51 <ul class="horizontal-list">

42 {{contact-developer-support-link[link] Developer Support}}	52 <li>

43 </a>	53 <a href="https://adblockplus.org/forum">

	54 {{contact-developer-support-link[link] Developer Support}}

	55 </a>

	56 </li>

	57 </ul>

44 </section>	58 </section>

45 </div>	59 </div>

46	60

47 </div>	61 </div><!-- .container -->

48 </section>	62 </aside>

LEFT	RIGHT