Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: skin/devtools-panel.css

Issue 29522650: Issue 5316 - Adds dynamic filter types to devtools panel (Closed)
Patch Set: Created Aug. 21, 2017, 3:24 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« messageResponder.js ('K') | « messageResponder.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skin/devtools-panel.css
===================================================================
--- a/skin/devtools-panel.css
+++ b/skin/devtools-panel.css
@@ -126,29 +126,16 @@
body.dark #items tr[data-state=whitelisted]
{
color: #389c22;
}
#items[data-filter-state=blocked] tr:not([data-state=blocked]),
#items[data-filter-state=whitelisted] tr:not([data-state=whitelisted]),
Thomas Greiner 2017/08/22 11:21:47 This is an invalid selector due to the trailing co
Jon Sonesen 2017/08/24 11:29:06 Acknowledged.
-#items[data-filter-type=SUBDOCUMENT] tr:not([data-type=SUBDOCUMENT]),
-#items[data-filter-type=IMAGE] tr:not([data-type=IMAGE]),
-#items[data-filter-type=STYLESHEET] tr:not([data-type=STYLESHEET]),
-#items[data-filter-type=SCRIPT] tr:not([data-type=SCRIPT]),
-#items[data-filter-type=OBJECT] tr:not([data-type=OBJECT]),
-#items[data-filter-type=XMLHTTPREQUEST] tr:not([data-type=XMLHTTPREQUEST]),
-#items[data-filter-type=FONT] tr:not([data-type=FONT]),
-#items[data-filter-type=PING] tr:not([data-type=PING]),
-#items[data-filter-type=POPUP] tr:not([data-type=POPUP]),
-#items[data-filter-type=ELEMHIDE] tr:not([data-type=ELEMHIDE]),
-#items[data-filter-type=WEBSOCKET] tr:not([data-type=WEBSOCKET]),
-#items[data-filter-type=WEBRTC] tr:not([data-type=WEBRTC]),
-#items[data-filter-type=OTHER] tr:not([data-type=OTHER])
Thomas Greiner 2017/08/22 11:21:47 Removing this code without an alternative solution
Jon Sonesen 2017/08/24 11:29:06 Is it better to just leave it then and add all pot
Thomas Greiner 2017/08/25 17:11:35 Since the ticket also refers to this CSS file I'd
{
display: none;
}
.changed, .unnamed
{
font-style: italic
}
« messageResponder.js ('K') | « messageResponder.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld