Issue 5556 - remove LogSystem setters

libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.libadblockplus.tests;
 
 import org.adblockplus.libadblockplus.AppInfo;
 import org.adblockplus.libadblockplus.JsEngine;
 import org.adblockplus.libadblockplus.LazyLogSystem;
+import org.adblockplus.libadblockplus.LogSystem;
 import org.adblockplus.libadblockplus.ThrowingWebRequest;
 
 import android.content.Context;
 import android.test.InstrumentationTestCase;
 
 public abstract class BaseJsTest extends InstrumentationTestCase
 {
   protected JsEngine jsEngine;
 
   @Override
   protected void setUp() throws Exception
   {
     super.setUp();
 
-    jsEngine = new JsEngine(AppInfo.builder().build());
-    jsEngine.setDefaultLogSystem();

[anton, 2017/08/24 11:23:44]

as far as i can see passing `null` as log system makes not invoking
'setLogSystem' in JniJsEngine.cpp and it's not equal to using DefaultLogSystem
as it was previously. Can you confirm no log system is used at all?

[sergei, 2017/08/24 11:38:26]

Right now default log system is created by JsEngine when JsEngine is being
created. In recent version of libadblockplus if log system is nullptr then it's
created when Platform is being created. So, in both cases a default log system
is used and in newer libadblockplus it's impossible to not use any log system.

+    jsEngine = new JsEngine(AppInfo.builder().build(), createLogSystem());
     jsEngine.setDefaultFileSystem(getContext().getFilesDir().getAbsolutePath());
     jsEngine.setWebRequest(new ThrowingWebRequest());
   }
 
+  protected LogSystem createLogSystem()
+  {
+    return null;

[anton, 2017/08/24 11:12:50]

comment like "returning null log system make JsEngine using default log system
impl" is needed

[sergei, 2017/08/24 13:39:10]

Done.

+  }
+
   protected Context getContext()
   {
     return getInstrumentation().getTargetContext();
   }
 }