Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/Platform.h

Issue 29527588: Issue 5570 - Make V8 isolate injectable into JsEngine (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created Aug. 25, 2017, 8:32 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/AdblockPlus/JsEngine.h ('k') | src/JsEngine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/Platform.h
diff --git a/include/AdblockPlus/Platform.h b/include/AdblockPlus/Platform.h
index c95204350c3af72af0eee70970636fcbd0101693..4e11ea6b46047a790c1e4f9d118ccd3e4fae4510 100644
--- a/include/AdblockPlus/Platform.h
+++ b/include/AdblockPlus/Platform.h
@@ -50,6 +50,7 @@ namespace AdblockPlus
*/
LogSystemPtr CreateDefaultLogSystem();
+ class IV8IsolateProvider;
class JsEngine;
/**
@@ -93,12 +94,14 @@ namespace AdblockPlus
~Platform();
/**
- * Ensures that JsEngine is constructed.
+ * Ensures that JsEngine is constructed. If JsEngine is already present
+ * then the parameters areignored.
hub 2017/08/25 13:20:39 typo: 'are ignored'
sergei 2017/08/25 15:02:53 Done.
*
- * @param appInfo Information about the app, if jsEngine is already present
- * then the value is ignored.
+ * @param appInfo Information about the app,
+ * @param isolate A provider of v8::Isolate, if the value is nullptr then
+ * a default implementation is used.
*/
- void SetUpJsEngine(const AppInfo& appInfo = AppInfo());
+ void SetUpJsEngine(const AppInfo& appInfo = AppInfo(), std::unique_ptr<IV8IsolateProvider> isolate = nullptr);
/**
* Retrieves the `JsEngine` instance. It calls SetUpJsEngine if JsEngine is
« no previous file with comments | « include/AdblockPlus/JsEngine.h ('k') | src/JsEngine.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld