Noissue - Use meson to build the C++ code

meson.build

-project('adblockpluscore', 'cpp', license: ['GPL3'])

[sergei, 2017/10/16 15:27:13]

I wonder how we plan to use it in the derived projects. In particular, there is
a concept of subprojects, should we leverage it?

+project('adblockpluscore', license: ['GPL3'], meson_version: '>0.40.0')
 
 # locate emscripten-config
 python = import('python3').find_python()
 emscripten_config = get_option('emscripten-config')
 command = run_command(python, '-c', 'import os.path, sys;print(os.path.expanduser(sys.argv[1]))', emscripten_config)
 if command.returncode() != 0
   error(command.stderr().strip())
 endif
 emscripten_config = command.stdout().strip()
 message('Emscripten config file: ' + emscripten_config)
@@ skipping 65 matching lines @@
 core_sources = [
   'compiled/traceInit.cpp',
 ]
 # sources for the bindings generator
 bindings_sources = [
   'compiled/bindings/generator.cpp',
   'compiled/bindings/main.cpp',
 ]
 
 defines_args = []
 foreach define : DEFINES

[sergei, 2017/10/16 15:27:12]

DEFINES is empty, it seems a good idea to keep it, though it's a dead code.

   defines_args += '-D' + define
 endforeach
 
 generation_args = []
 foreach param : GENERATION_PARAMS
   generation_args += '-s'
   generation_args += param[0] + '=' + '@0@'.format(param[1])
 endforeach
 
 optional_args = []
 buildtype = get_option('buildtype')
 if buildtype.startswith('debug')
+  optional_args += '-DDEBUG'
   optional_args += '-g3'

[sergei, 2017/10/16 15:27:13]

We need to check why -g3 is added twice.

 endif
 tracing = get_option('tracing')
 if tracing
   optional_args += '--tracing'
 endif
 
-compiler_args = defines_args + generation_args + optional_args + ADDITIONAL_PARAMS

[sergei, 2017/10/16 15:27:12]

optional_args are included two times, the second time on the lines 118 and 166.

[hub, 2017/10/26 16:15:27]

good catch.

+compiler_args = defines_args + generation_args + ADDITIONAL_PARAMS
 
 # build objects.
 core_objects = []
 bindings_objects = []
 shared_objects = []
 foreach group : ['core', 'bindings', 'shared']
   objects = []
   foreach source_file : get_variable(group + '_sources')
     output_file = source_file.underscorify() + '.o'
     command = [ emcc, '-MD', '-MF', '@DEPFILE@', '-c', '-o', '@OUTPUT@',
@@ skipping 27 matching lines @@
                                      '@INPUT@'
                                    ])
 # run the binding generator
 bindings_output = custom_target(BINDINGS_OUTPUT,
                                 input: bindings_generator,
                                 output: BINDINGS_OUTPUT,
                                 capture: true,
                                 command: [nodejs, '@INPUT@'])
 
 # link the core
 output_file = join_paths(meson.source_root(), 'lib', COMPILER_OUTPUT)

[sergei, 2017/10/16 15:27:12]

On 2017/10/11 10:00:47, Wladimir Palant wrote:
https://codereview.adblockplus.org/29527808/diff/29532724/meson.build#newcode93
Can we put a #TODO: here? Optionally include a reminder to update README.md
(currently it's line 42).

 compiler_output = custom_target(COMPILER_OUTPUT,
                                 build_by_default: true,
                                 input: core_objects + shared_objects,
                                 output: COMPILER_OUTPUT,
                                 depend_files: [ JS_LIBRARY ],
                                 command: [
                                   emcc, '-o', output_file,
                                   '--post-js', bindings_output,
                                   '--js-library', JS_LIBRARY,
                                   '@INPUT@'
                                 ] + compiler_args + optional_args)