Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/uninstalled.tmpl

Issue 29530567: Noissue - Translating uninstalled page (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Created Aug. 29, 2017, 12:06 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pages/uninstalled.tmpl
===================================================================
--- a/pages/uninstalled.tmpl
+++ b/pages/uninstalled.tmpl
@@ -1,11 +1,22 @@
title=Adblock Plus has been uninstalled
template=simple
+{# reasons[0] is reasonId below and is formatted as follows:
+ #
+ # ${reason_id}v${version_of_wording}-${locale}
+ #
+ # ${reason_id}: Each reason should have it's own unique ID
+ # (because they will appear in random order)
+ # ${version_of_wording}: Each reason wording should be versioned
+ # (in case we update the wording in the future)
+ # ${locale}: Locale (added in loop below)
+ #}
+
{% set reasons = [
("1v0", "reason-not-installed", "I didn't install Adblock Plus.", ""),
("2v0", "reason-slowing-down", "Adblock Plus slowed down my browser.", ""),
("3v0", "reason-acceptable-ads", "I don't like the Acceptable Ads program.", ""),
("4v0", "reason-see-ads", "Adblock Plus didn't block all ads.", ""),
("5v0", "reason-better-adblocker", "I found better ad blocking software.", ["AdBlock", "uBlock", "uBlock Origin", "Ghostery"]),
("6v0", "reason-break-websites", "Adblock Plus breaks websites that I visit.", ""),
("7v0", "reason-difficult", "I find it difficult to use Adblock Plus.", ""),
@@ -117,17 +128,17 @@
<section class="highlighted">
<h1>{{"Please select the reason(s) why you uninstalled Adblock Plus:"|translate("reasons-header", "Form heading")}}</h1>
<form id="reasons-form" action="uninstalled-submit" method="get">
<fieldset>
<ul id="reasons">
{%- for reasonId, stringId, value, adblockers in reasons %}
<li>
<label>
- <input type="checkbox" name="reason" {% if adblockers %} data-toggle-view="adblockers" {% endif %} value="{{reasonId}}" />
+ <input type="checkbox" name="reason" {% if adblockers %} data-toggle-view="adblockers" {% endif %} value="{{reasonId}}-{{locale}}" />
{{value|translate(stringId, "Uninstallation reason")}}
</label>
{%- if adblockers %}
<fieldset class="hidden" id="adblockers">
<select name="otherAdblockerPredefined">
{%- for name in adblockers %}
<option data-hide-element="other-adblocker" value="{{name}}">{{name}}</option>
{%- endfor %}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld