Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: skin/mobile-options.css

Issue 29531693: Noissue - Fixed: Button in filter list selection dialog is squashed (Closed)
Left Patch Set: Created Aug. 30, 2017, 3:45 p.m.
Right Patch Set: Allow list buttons to grow in height Created Sept. 15, 2017, 12:56 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 } 190 }
191 191
192 input:checked + .toggle-image 192 input:checked + .toggle-image
193 { 193 {
194 background-image: url(mobile/toggle.svg#on); 194 background-image: url(mobile/toggle.svg#on);
195 } 195 }
196 196
197 button 197 button
198 { 198 {
199 width: 100%; 199 width: 100%;
200 height: 46px; /* equal to height of list item */
201 border: none; 200 border: none;
202 font-weight: 600; 201 font-weight: 600;
203 text-transform: uppercase; 202 text-transform: uppercase;
204 color: #099DD1; 203 color: #099DD1;
205 background: none; 204 background: none;
206 } 205 }
207 206
208 button.primary, 207 button.primary,
209 button.secondary 208 button.secondary
210 { 209 {
(...skipping 20 matching lines...) Expand all
231 { 230 {
232 width: 36px; 231 width: 36px;
233 height: 36px; 232 height: 36px;
234 padding: 0; 233 padding: 0;
235 background-color: #099DD1; 234 background-color: #099DD1;
236 mask: url(mobile/trash.svg) center/19px no-repeat; 235 mask: url(mobile/trash.svg) center/19px no-repeat;
237 } 236 }
238 237
239 ul + button 238 ul + button
240 { 239 {
240 flex-shrink: 0;
241 width: 100%; 241 width: 100%;
242 padding: 0 20px; /* based on margin and padding of list item */ 242 min-height: 46px; /* equal to min-height of list item */
243 padding: 15px 20px; /* based on margin and padding of list item */
243 border: 1px solid #BBBBBB; 244 border: 1px solid #BBBBBB;
244 text-align: start; 245 text-align: start;
245 } 246 }
246 247
247 /* Dialogs */ 248 /* Dialogs */
248 249
249 #dialog 250 #dialog
250 { 251 {
251 display: flex; 252 display: flex;
252 align-items: flex-start; 253 align-items: flex-start;
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 } 362 }
362 363
363 #dialog-recommended ul li.installed::before 364 #dialog-recommended ul li.installed::before
364 { 365 {
365 background-color: #BBBBBB; 366 background-color: #BBBBBB;
366 mask: url(mobile/checkmark.svg) center/cover no-repeat; 367 mask: url(mobile/checkmark.svg) center/cover no-repeat;
367 } 368 }
368 369
369 #dialog-recommended > button 370 #dialog-recommended > button
370 { 371 {
371 flex-shrink: 0;
saroyanm 2017/09/14 13:45:40 The button still is being squashed with this prope
saroyanm 2017/09/14 13:49:12 Sorry, this was a cache error :/ Looks fine.
saroyanm 2017/09/14 13:57:53 Deatil: But using Padding instead of Height might
Thomas Greiner 2017/09/15 13:00:03 You're right regarding longer texts. Done. I made
372 border-width: 1px 0 0 0; 372 border-width: 1px 0 0 0;
373 text-align: center; 373 text-align: center;
374 } 374 }
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld