Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: ext/popup.js

Issue 29532767: Issue 5593 - Use messaging in popup for prefs, whitelisting, and stats (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Use messaging for prefs in stats.js Created Sept. 1, 2017, 3:51 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | popup.html » ('j') | stats.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 "use strict"; 1 "use strict";
2 2
3 (function() 3 (function()
4 { 4 {
5 if (typeof chrome == "undefined" || typeof chrome.extension == "undefined") 5 if (typeof chrome == "undefined" || typeof chrome.extension == "undefined")
6 window.chrome = browser; 6 window.chrome = browser;
7 const backgroundPage = chrome.extension.getBackgroundPage(); 7 const backgroundPage = chrome.extension.getBackgroundPage();
8 window.ext = Object.create(backgroundPage.ext); 8 window.ext = Object.create(backgroundPage.ext);
9 9
10 window.ext.closePopup = () =>
11 {
12 window.close();
13 };
14
15 // Calling i18n.getMessage from the background page causes Edge to throw an 10 // Calling i18n.getMessage from the background page causes Edge to throw an
16 // exception. 11 // exception.
17 // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/127939 75/ 12 // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/127939 75/
18 window.ext.i18n = chrome.i18n; 13 window.ext.i18n = chrome.i18n;
19 14
20 // We have to override ext.backgroundPage, because in order 15 // We have to override ext.backgroundPage, because in order
21 // to send messages the local "chrome" namespace must be used. 16 // to send messages the local "chrome" namespace must be used.
22 window.ext.backgroundPage = { 17 window.ext.backgroundPage = {
23 sendMessage: chrome.runtime.sendMessage, 18 sendMessage: chrome.runtime.sendMessage,
24 19
25 getWindow() 20 getWindow()
26 { 21 {
27 return backgroundPage; 22 return backgroundPage;
28 } 23 }
29 }; 24 };
25
26 window.ext.closePopup = () =>
27 {
28 window.close();
29 };
30
31 window.ext.prefs = {
32 get(key, callback)
33 {
34 chrome.runtime.sendMessage({type: "prefs.get", key}, callback);
35 },
36 toggle(key, callback)
Manish Jethani 2017/09/01 15:56:20 The callback will be needed here if 29533613 lands
37 {
38 chrome.runtime.sendMessage({type: "prefs.toggle", key}, callback);
39 }
40 };
30 }()); 41 }());
OLDNEW
« no previous file with comments | « no previous file | popup.html » ('j') | stats.js » ('J')

Powered by Google App Engine
This is Rietveld