Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java

Issue 29536596: Issue 5556 - Update to use libadblockplus revision hg:566f64c8a2a8 (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git
Patch Set: Created Sept. 5, 2017, 12:21 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/GlobalJsObjectTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java
diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java
index 4e4dd0d51b2c1cf8f666d36ad5ef80db1662dbb3..b968565effe1a04de4d8d3eefefd1fd40533965c 100644
--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java
+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java
@@ -42,7 +42,7 @@ public class AndroidWebRequestTest extends BaseJsTest
// This URL should redirect to easylist-downloads.adblockplus.org and we
// should get the actual filter list back.
jsEngine.evaluate(
- "_webRequest.GET('https://easylist-downloads.adblockplus.org/easylist.txt', {}, " +
+ "let foo; _webRequest.GET('https://easylist-downloads.adblockplus.org/easylist.txt', {}, " +
"function(result) {foo = result;} )");
do
{
@@ -54,7 +54,7 @@ public class AndroidWebRequestTest extends BaseJsTest
{
throw new RuntimeException(e);
}
- } while (jsEngine.evaluate("this.foo").isUndefined());
+ } while (jsEngine.evaluate("foo").isUndefined());
String response = jsEngine.evaluate("foo.responseText").asString();
assertNotNull(response);
« no previous file with comments | « no previous file | libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/GlobalJsObjectTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld