Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: include/AdblockPlus/Platform.h

Issue 29536678: Noissue - fix a warning class 'IV8IsolateProvider' was previously declared as a struct [-Wmismatche… (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Created Sept. 5, 2017, 3:43 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 /** 43 /**
44 * A factory to construct DefaultWebRequest. 44 * A factory to construct DefaultWebRequest.
45 */ 45 */
46 WebRequestPtr CreateDefaultWebRequest(const Scheduler& scheduler, WebRequestSy ncPtr syncImpl = nullptr); 46 WebRequestPtr CreateDefaultWebRequest(const Scheduler& scheduler, WebRequestSy ncPtr syncImpl = nullptr);
47 47
48 /** 48 /**
49 * A factory to construct LogSystem. 49 * A factory to construct LogSystem.
50 */ 50 */
51 LogSystemPtr CreateDefaultLogSystem(); 51 LogSystemPtr CreateDefaultLogSystem();
52 52
53 class IV8IsolateProvider; 53 struct IV8IsolateProvider;
sergei 2017/09/05 17:54:51 LGTM.
54 class JsEngine; 54 class JsEngine;
55 55
56 /** 56 /**
57 * AdblockPlus platform is the main component providing access to other 57 * AdblockPlus platform is the main component providing access to other
58 * modules. 58 * modules.
59 * 59 *
60 * It manages the functionality modules, e.g. JsEngine and FilterEngine as 60 * It manages the functionality modules, e.g. JsEngine and FilterEngine as
61 * well as allows to correctly work with asynchronous functionality. 61 * well as allows to correctly work with asynchronous functionality.
62 */ 62 */
63 class Platform 63 class Platform
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 FileSystemPtr fileSystem; 153 FileSystemPtr fileSystem;
154 WebRequestPtr webRequest; 154 WebRequestPtr webRequest;
155 // used for creation and deletion of modules. 155 // used for creation and deletion of modules.
156 std::mutex modulesMutex; 156 std::mutex modulesMutex;
157 std::shared_ptr<JsEngine> jsEngine; 157 std::shared_ptr<JsEngine> jsEngine;
158 std::shared_future<FilterEnginePtr> filterEngine; 158 std::shared_future<FilterEnginePtr> filterEngine;
159 }; 159 };
160 } 160 }
161 161
162 #endif // ADBLOCK_PLUS_PLATFORM_H 162 #endif // ADBLOCK_PLUS_PLATFORM_H
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld