Delta Between Two Patch Sets: scss/_content.scss
Issue 29538612:
Issue 5607 - Namespace content styles in website-defaults (Closed)
Base URL: https://hg.adblockplus.org/website-defaults
Left Patch Set: Move global content styles to _reset.scss
Created Sept. 11, 2017, 11:11 a.m.
Right Patch Set: Addressed NITs
Created Sept. 12, 2017, 7:46 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
scss/_reset.scss » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 /*! | 1 /*! |
| 2 * This file is part of website-defaults | 2 * This file is part of website-defaults |
| 3 * Copyright (C) 2016-present eyeo GmbH | 3 * Copyright (C) 2016-present eyeo GmbH |
| 4 * | 4 * |
| 5 * website-defaults is free software: you can redistribute it and/or | 5 * website-defaults is free software: you can redistribute it and/or |
| 6 * modify it under the terms of the GNU General Public License as published by | 6 * modify it under the terms of the GNU General Public License as published by |
| 7 * the Free Software Foundation, either version 3 of the License, or | 7 * the Free Software Foundation, either version 3 of the License, or |
| 8 * (at your option) any later version. | 8 * (at your option) any later version. |
| 9 * | 9 * |
| 10 * website-defaults is distributed in the hope that it will be useful, | 10 * website-defaults is distributed in the hope that it will be useful, |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 21 ******************************************************************************* | 21 ******************************************************************************* |
| 22 * 1. Document | 22 * 1. Document |
| 23 * 2. Headings | 23 * 2. Headings |
| 24 * 3. Body content | 24 * 3. Body content |
| 25 ******************************************************************************/ | 25 ******************************************************************************/ |
| 26 | 26 |
| 27 .content | 27 .content |
| 28 { | 28 { |
| 29 | 29 |
| 30 /* Document | 30 /* Document |
| 31 ****************************************************************************** / | 31 ****************************************************************************/ |
|
juliandoucette
2017/09/11 15:54:34
NIT: Are these lines too long now that they are in
ire
2017/09/12 07:47:05
They were longer by just 2 spaces, so I shortened
| |
| 32 | 32 |
| 33 p, | 33 p, |
| 34 ol, | 34 ol, |
| 35 ul, | 35 ul, |
| 36 dl, | 36 dl, |
| 37 pre, | 37 pre, |
| 38 blockquote | 38 blockquote |
| 39 { | 39 { |
| 40 /* Set consistent margins (opinionated) */ | 40 /* Set consistent margins (opinionated) */ |
| 41 margin: 1em 0em; | 41 margin: 1em 0em; |
| 42 } | 42 } |
| 43 | 43 |
| 44 /* Headings | 44 /* Headings |
| 45 ****************************************************************************** / | 45 ****************************************************************************/ |
| 46 | 46 |
| 47 h1, | 47 h1, |
| 48 h2, | 48 h2, |
| 49 h3, | 49 h3, |
| 50 h4, | 50 h4, |
| 51 h5, | 51 h5, |
| 52 h6 | 52 h6 |
| 53 { | 53 { |
| 54 /* Margin on top **only** (opinionated) */ | 54 /* Margin on top **only** (opinionated) */ |
| 55 margin: 2em 0em 0.5em 0em; | 55 margin: 2em 0em 0.5em 0em; |
| (...skipping 23 matching lines...) Expand all Loading... | |
| 79 { | 79 { |
| 80 font-size: 0.8em; | 80 font-size: 0.8em; |
| 81 } | 81 } |
| 82 | 82 |
| 83 h6 | 83 h6 |
| 84 { | 84 { |
| 85 font-size: 0.7em; | 85 font-size: 0.7em; |
| 86 } | 86 } |
| 87 | 87 |
| 88 /* Body content | 88 /* Body content |
| 89 ****************************************************************************** / | 89 ****************************************************************************/ |
| 90 | 90 |
| 91 a, | 91 a, |
| 92 a:visited | 92 a:visited |
| 93 { | 93 { |
| 94 color: $accent; | 94 color: $accent; |
| 95 } | 95 } |
| 96 | 96 |
| 97 hr | 97 hr |
| 98 { | 98 { |
| 99 border: 1px solid $secondary-light; | 99 border: 1px solid $secondary-light; |
| (...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 159 { | 159 { |
| 160 /* undo browser default (opinionated)*/ | 160 /* undo browser default (opinionated)*/ |
| 161 font-weight: $bold-weight; | 161 font-weight: $bold-weight; |
| 162 } | 162 } |
| 163 | 163 |
| 164 dd | 164 dd |
| 165 { | 165 { |
| 166 margin: 0.25em 0em 1em 0em; | 166 margin: 0.25em 0em 1em 0em; |
| 167 } | 167 } |
| 168 } | 168 } |
| LEFT | RIGHT |
« no previous file
|
scss/_reset.scss » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
