scss/_variables.scss - Issue 29539827: Noissue - Added configurable breakpoints and phablet widths to grid

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: scss/_variables.scss

Issue 29539827: Noissue - Added configurable breakpoints and phablet widths to grid (Closed) Base URL: https://hg.adblockplus.org/website-defaults

Left Patch Set: Created Sept. 8, 2017, 4:17 p.m.

Right Patch Set: Renamed mobile to phone Created Sept. 11, 2017, 4:01 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*!	1 /*!

2 * This file is part of website-defaults	2 * This file is part of website-defaults

3 * Copyright (C) 2016-present eyeo GmbH	3 * Copyright (C) 2016-present eyeo GmbH

4 *	4 *

5 * website-defaults is free software: you can redistribute it and/or	5 * website-defaults is free software: you can redistribute it and/or

6 * modify it under the terms of the GNU General Public License as published by	6 * modify it under the terms of the GNU General Public License as published by

7 * the Free Software Foundation, either version 3 of the License, or	7 * the Free Software Foundation, either version 3 of the License, or

8 * (at your option) any later version.	8 * (at your option) any later version.

9 *	9 *

10 * website-defaults is distributed in the hope that it will be useful,	10 * website-defaults is distributed in the hope that it will be useful,

(...skipping 70 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
81 ******************************************************************************/	81 ******************************************************************************/

82	82

83 $phone-breakpoint: 320px !default;	83 $phone-breakpoint: 320px !default;

84 $phablet-breakpoint: 576px !default;	84 $phablet-breakpoint: 576px !default;

85 $tablet-breakpoint: 768px !default;	85 $tablet-breakpoint: 768px !default;

86 $desktop-breakpoint: 992px !default;	86 $desktop-breakpoint: 992px !default;

87	87

88 /* Container widths	88 /* Container widths

89 ******************************************************************************/	89 ******************************************************************************/

90	90

91 $mobile-width: auto !default;	91 $phone-width: auto !default;
juliandoucette 2017/09/08 17:05:46 Make up your mind Julian "phone" or "mobile" IDK : Make up your mind Julian "phone" or "mobile" IDK :D ire 2017/09/11 07:55:17 Haha. I think $phone may be more accurate, since p Show quoted text On 2017/09/08 17:05:46, juliandoucette wrote: > Make up your mind Julian "phone" or "mobile" IDK :D Haha. I think $phone may be more accurate, since phablets/tablets are technically "mobile"
92 $phablet-width: 540px !default;	92 $phablet-width: 540px !default;

93 $tablet-width: 720px !default;	93 $tablet-width: 720px !default;

94 $desktop-width: 960px !default;	94 $desktop-width: 960px !default;

LEFT	RIGHT