Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: stylelint-config-eyeo/index.js

Issue 29541680: Issue 5109 - Create stylelintrc for websites and ui modules (Closed) Base URL: https://hg.adblockplus.org/codingtools
Patch Set: Remove comments with no rules, allow no-empty line after-comment and inside-block Created Oct. 30, 2017, 8:29 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « stylelint-config-eyeo/README.md ('k') | stylelint-config-eyeo/package.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: stylelint-config-eyeo/index.js
===================================================================
new file mode 100644
--- /dev/null
+++ b/stylelint-config-eyeo/index.js
@@ -0,0 +1,72 @@
+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
juliandoucette 2017/10/31 14:22:45 This isn't part of adblockplus.org
ire 2017/11/01 11:06:09 This is the same licence header from eslint-config
juliandoucette 2017/11/01 13:14:26 @kzar do you consider this and eslint-config-eyeo
kzar 2017/11/03 13:38:38 I would check with legal, it's quite possible I ju
+ * Copyright (C) 2006-present eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+"use strict";
+
+module.exports = {
+ extends: "stylelint-config-recommended",
+ rules: {
+ // Opening braces go on their own line
+ "block-closing-brace-empty-line-before": "never",
+ "block-closing-brace-newline-after": "always",
+ "block-closing-brace-newline-before": "always-multi-line",
+ "block-opening-brace-newline-after": "always-multi-line",
+ "block-opening-brace-newline-before": "always-multi-line",
+
+ // Use a space between the last selector and the declaration block
+ "block-closing-brace-space-after": "always-single-line",
+ "block-closing-brace-space-before": "always-single-line",
+ "block-opening-brace-space-after": "always-single-line",
juliandoucette 2017/10/31 14:22:45 Suggest: Open before close? (very opinionated - ig
ire 2017/11/01 11:06:09 I agree. And I also think: opening before > openin
ire 2017/11/01 11:06:10 Done.
+ "block-opening-brace-space-before": "always-single-line",
+
+ // Use a space after a property name’s colon.
+ "declaration-colon-space-after": "always",
+
+ // Separate selectors and declarations by new lines.
+ "selector-list-comma-newline-after": "always",
+ "declaration-block-semicolon-newline-after": "always-multi-line",
+
+ // Separate rules by new lines.
+ "rule-empty-line-before": ["always", {
+ "ignore": ["after-comment", "inside-block"]
+ }],
+
+ // Use double over single quotation marks
+ "string-quotes": "double",
+
+ // CSS color values should be specified in hexadecimal where possible
+ "color-named": "never",
+
+ // Use 3 character hexadecimal notation where possible.
+ "color-hex-length": "short",
+
+ // Don't omit the optional leading 0 for decimal numbers
+ "number-leading-zero": "always",
+ "number-no-trailing-zeros": true,
+
+ // Two spaces per logic level
+ "indentation": 2,
+
+ // Line length should be 80 characters or less
+ "max-line-length": 80,
+
+ // Avoid qualifying ID and class names with type selectors.
+ "selector-no-qualifying-type": [true, {
+ "ignore": ["attribute"]
+ }]
+ }
+};
« no previous file with comments | « stylelint-config-eyeo/README.md ('k') | stylelint-config-eyeo/package.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld