Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: messageResponder.js

Issue 29544706: Noissue - Adapt check for devtools panel support for Firefox (Closed)
Patch Set: Use compareVersion from coreUtils Created Sept. 18, 2017, 6:20 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « background.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: messageResponder.js
===================================================================
--- a/messageResponder.js
+++ b/messageResponder.js
@@ -25,6 +25,7 @@
const {port} = require("messaging");
const {Prefs} = require("prefs");
+ const {compareVersion} = require("coreUtils");
const {Utils} = require("utils");
const {FilterStorage} = require("filterStorage");
const {FilterNotifier} = require("filterNotifier");
@@ -184,7 +185,9 @@
if (message.what == "features")
{
return {
- devToolsPanel: info.platform == "chromium"
+ devToolsPanel: info.platform == "chromium" ||
+ info.application == "firefox" &&
+ compareVersion(info.applicationVersion, "54") >= 0
};
}
« no previous file with comments | « background.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld