Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: new-options.js

Issue 29549891: Issue 5706 - Finish custom filter list dialog (Closed)
Left Patch Set: Addressed Ire's comments Created Sept. 21, 2017, 7:08 p.m.
Right Patch Set: fixed Nit Created Sept. 22, 2017, 9:44 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « new-options.html ('k') | skin/icons/attention.svg » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 666 matching lines...) Expand 10 before | Expand all | Expand 10 after
677 url: findParentData(element, "access", false) 677 url: findParentData(element, "access", false)
678 }); 678 });
679 break; 679 break;
680 case "validate-import-subscription": 680 case "validate-import-subscription":
681 let form = findParentData(element, "validation", true); 681 let form = findParentData(element, "validation", true);
682 if (!form) 682 if (!form)
683 return; 683 return;
684 684
685 if (form.checkValidity()) 685 if (form.checkValidity())
686 { 686 {
687 addEnableSubscription(E("import-list-url").value, 687 addEnableSubscription(E("import-list-url").value,
ire 2017/09/22 08:28:53 NIT: I'm getting an eslint error here: "no-trailin
saroyanm 2017/09/22 09:46:58 Done.
688 E("import-list-title").value); 688 E("import-list-title").value);
689 form.reset(); 689 form.reset();
690 closeDialog(); 690 closeDialog();
691 } 691 }
692 else 692 else
693 { 693 {
694 form.querySelector(":invalid").focus(); 694 form.querySelector(":invalid").focus();
695 } 695 }
696 break; 696 break;
697 } 697 }
(...skipping 652 matching lines...) Expand 10 before | Expand all | Expand 10 after
1350 }); 1350 });
1351 ext.backgroundPage.sendMessage({ 1351 ext.backgroundPage.sendMessage({
1352 type: "subscriptions.listen", 1352 type: "subscriptions.listen",
1353 filter: ["added", "disabled", "homepage", "lastDownload", "removed", 1353 filter: ["added", "disabled", "homepage", "lastDownload", "removed",
1354 "title", "downloadStatus", "downloading"] 1354 "title", "downloadStatus", "downloading"]
1355 }); 1355 });
1356 1356
1357 window.addEventListener("DOMContentLoaded", onDOMLoaded, false); 1357 window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
1358 window.addEventListener("hashchange", onHashChange, false); 1358 window.addEventListener("hashchange", onHashChange, false);
1359 } 1359 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld