modules/adblockplus/files/nginx/fileserver.conf - Issue 29551585: #2317 - provide role fileserver for eyeofiles.com

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: modules/adblockplus/files/nginx/fileserver.conf

Issue 29551585: #2317 - provide role fileserver for eyeofiles.com (Closed) Base URL: https://hg1/infrastructure

Patch Set: use single nginx conf based on $host Created Sept. 25, 2017, 11:24 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Generated by puppet module adblockplus::web::fileserver
	mathias 2017/09/25 17:06:03 Use `# Puppet: <%= $title %>` to not hard-code the Use `# Puppet: <%= $title %>` to not hard-code the caller here. f.nicolaisen 2017/09/25 20:21:18 Should I switch this static file to be a template Show quoted text On 2017/09/25 17:06:03, mathias wrote: > Use `# Puppet: <%= $title %>` to not hard-code the caller here. Should I switch this static file to be a template for only that reason? mathias 2017/09/25 21:08:50 You can also remove that stuff, or just use anothe Show quoted text On 2017/09/25 20:21:18, f.nicolaisen wrote: > On 2017/09/25 17:06:03, mathias wrote: > > Use `# Puppet: <%= $title %>` to not hard-code the caller here. > > Should I switch this static file to be a template for only that reason? You can also remove that stuff, or just use another term than "generated" (i.e. "managed") and leave the class name out of there. f.nicolaisen 2017/09/25 21:19:47 Acknowledged. Show quoted text On 2017/09/25 21:08:50, mathias wrote: > On 2017/09/25 20:21:18, f.nicolaisen wrote: > > On 2017/09/25 17:06:03, mathias wrote: > > > Use `# Puppet: <%= $title %>` to not hard-code the caller here. > > > > Should I switch this static file to be a template for only that reason? > > You can also remove that stuff, or just use another term than "generated" (i.e. > "managed") and leave the class name out of there. Acknowledged.
	2 location / {

	3 root /var/www/$host;

	4 }

	5

OLD	NEW