Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: README.md

Issue 29557565: Issue 5800 - Add option to specify a list of V8 libraries (Closed)
Patch Set: Renamed env. variable Created Sept. 29, 2017, 8:27 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | libadblockplus-android/jni/Android.mk » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Adblock Plus Library for Android 1 Adblock Plus Library for Android
2 ================================ 2 ================================
3 3
4 An Android library project, tests and demo application for AdblockWebView widget . 4 An Android library project, tests and demo application for AdblockWebView widget .
5 5
6 ## Updating the dependencies 6 ## Updating the dependencies
7 7
8 Adblock Plus for Android has dependencies that aren't in this repository. 8 Adblock Plus for Android has dependencies that aren't in this repository.
9 To update those, call: 9 To update those, call:
10 10
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 This will generate *.aar library artifact in the 'libadblockplus-android/build/o utputs/aar/' directory. 84 This will generate *.aar library artifact in the 'libadblockplus-android/build/o utputs/aar/' directory.
85 85
86 **Android permissions note** 86 **Android permissions note**
87 87
88 An app that uses the library have to add the following permissions to `AndroidMa nifest.xml`: 88 An app that uses the library have to add the following permissions to `AndroidMa nifest.xml`:
89 * `<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>` 89 * `<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>`
90 * `<uses-permission android:name="android.permission.ACCESS_WIFI_STATE"/>` 90 * `<uses-permission android:name="android.permission.ACCESS_WIFI_STATE"/>`
91 91
92 (added automatically if building with Gradle or should be added manually otherwi se). 92 (added automatically if building with Gradle or should be added manually otherwi se).
93 93
94 ### Building with prebuilt shared V8
95
96 This can be desired to use product's V8 (let's say Chromium) instead of libadblo ckplus built-in V8.
sergei 2017/09/29 08:35:41 I would replace "libadblockplus built-in V8" by "V
anton 2017/09/29 08:43:51 The user can be not aware of internal structure of
sergei 2017/09/29 09:21:05 OK, but V8 is not build-in, libadblockplus.a is no
anton 2017/09/29 11:45:28 Acknowledged.
97 Put prebuilt shared V8 library file(s) in ARCH directories and set `SHARED_V8_LI B_FILENAMES`
98 environment variable before building. You can pass multiple filenames, separated with `:`.
sergei 2017/09/29 08:35:41 Why not separate them by spaces instead of `:`?
anton 2017/09/29 08:43:51 Does it make sense what separator? ":" standard s
sergei 2017/09/29 09:21:04 On windows the standard path separator is ; becaus
anton 2017/09/29 11:45:28 Let's have ',' as working for all solution.
99 Libadblockplus is required to be linked with that library file(s).
sergei 2017/09/29 08:35:41 actually not "Libadblockplus" but libadblockplus-a
anton 2017/09/29 08:43:51 I've meant libadblockplus actually. To be more det
sergei 2017/09/29 09:21:04 Acknowledged. Maybe we should say that this librar
anton 2017/09/29 11:45:29 I'm not sure it's required for most users. And it
100
101 For example (build with Gradle):
102
103 SHARED_V8_LIB_FILENAMES=libv8.cr.so ./gradlew clean assemble
104
105 or
106
107 SHARED_V8_LIB_FILENAMES=libv8.cr.so:libfoo.so ./gradlew clean assemble
108
109 for multiple library files.
110
111 Note
112
113 [Configuration] Linking dynamically with shared v8 library ./libadblockplus- binaries/android_armeabi-v7a/libv8.cr.so
114
115 output while building native library.
116
94 ## Library tests 117 ## Library tests
95 118
96 Android tests for the library. 119 Android tests for the library.
97 You can find them in the 'libadblockplus-android-tests' directory. 120 You can find them in the 'libadblockplus-android-tests' directory.
98 121
99 ### Requirements 122 ### Requirements
100 123
101 Make sure _Library_ requirements are present. 124 Make sure _Library_ requirements are present.
102 125
103 ### Building with Ant 126 ### Building with Ant
(...skipping 194 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 321
299 This will generate *.apk in the 'libadblockplus-android-webviewapp/bin/' directo ry. 322 This will generate *.apk in the 'libadblockplus-android-webviewapp/bin/' directo ry.
300 323
301 #### Building with Gradle 324 #### Building with Gradle
302 325
303 In the project root directory run: 326 In the project root directory run:
304 327
305 ./gradlew assemble 328 ./gradlew assemble
306 329
307 This will generate *.apk in the 'libadblockplus-android-webviewapp/build/outputs /apk/' directory. 330 This will generate *.apk in the 'libadblockplus-android-webviewapp/build/outputs /apk/' directory.
OLDNEW
« no previous file with comments | « no previous file | libadblockplus-android/jni/Android.mk » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld