Issue 4699 - Edge does not support 16px and 32px icons

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 325 matching lines @@
     _applyChanges()
     {
       if ("iconPath" in this._changes)
       {
         // Firefox for Android displays the browser action not as an icon but
         // as a menu item. There is no icon, but such an option may be added in
         // the future.
         // https://bugzilla.mozilla.org/show_bug.cgi?id=1331746
         if ("setIcon" in chrome.browserAction)
         {
+          let path = {
+            16: this._changes.iconPath.replace("$size", "16"),
+            19: this._changes.iconPath.replace("$size", "19"),
+            20: this._changes.iconPath.replace("$size", "20"),
+            32: this._changes.iconPath.replace("$size", "32"),
+            38: this._changes.iconPath.replace("$size", "38"),
+            40: this._changes.iconPath.replace("$size", "40")
+          };
           try
           {
-            chrome.browserAction.setIcon({
-              tabId: this._tabId,
-              path: {
-                16: this._changes.iconPath.replace("$size", "16"),
-                19: this._changes.iconPath.replace("$size", "19"),
-                20: this._changes.iconPath.replace("$size", "20"),
-                32: this._changes.iconPath.replace("$size", "32"),
-                38: this._changes.iconPath.replace("$size", "38"),
-                40: this._changes.iconPath.replace("$size", "40")
-              }
-            });
+            chrome.browserAction.setIcon({tabId: this._tabId, path});
           }
           catch (e)
           {
             // Edge throws if passed icon sizes different than 19,20,38,40px.
-            chrome.browserAction.setIcon({
-              tabId: this._tabId,
-              path: {
-                19: this._changes.iconPath.replace("$size", "19"),
-                20: this._changes.iconPath.replace("$size", "20"),
-                38: this._changes.iconPath.replace("$size", "38"),
-                40: this._changes.iconPath.replace("$size", "40")
-              }
-            });
+            delete path[16];
+            delete path[32];
+            chrome.browserAction.setIcon({tabId: this._tabId, path});
           }

[Sebastian Noack, 2017/09/27 21:00:40]

We can avoid duplication here:

  let path = {
    16: this._changes.iconPath.replace("$size", "16"),
    19: this._changes.iconPath.replace("$size", "19"),
    20: this._changes.iconPath.replace("$size", "20"),
    32: this._changes.iconPath.replace("$size", "32"),
    38: this._changes.iconPath.replace("$size", "38"),
    40: this._changes.iconPath.replace("$size", "40")
  };

  try
  {
    chrome.browserAction.setIcon({tabId: this._tabId, path});
  }
  catch (e)
  {
    // Edge throws if passed icon sizes different than 19,20,38,40px.
    delete path[16];
    delete path[32];
    chrome.browserAction.setIcon({tabId: this._tabId, path});
  }

         }
       }
 
       if ("badgeText" in this._changes)
       {
         // There is no badge on Firefox for Android; the browser action is
         // simply a menu item.
         if ("setBadgeText" in chrome.browserAction)
         {
           chrome.browserAction.setBadgeText({
@@ skipping 410 matching lines @@
   ext.windows = {
     create(createData, callback)
     {
       chrome.windows.create(createData, createdWindow =>
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 }());