Issue 5572 - fix stringBeginsWith in Util.cpp

libadblockplus-android/jni/Utils.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 87 matching lines @@
   return ret;
 }
 
 jstring JniStdStringToJava(JNIEnv* env, std::string str)
 {
   return env->NewStringUTF(str.c_str());
 }
 
 bool stringBeginsWith(const std::string& string, const std::string& beginning)
 {
-  return string.compare(0, beginning.length(), beginning);
+  return string.compare(0, beginning.length(), beginning) == 0;

[sergei, 2017/09/28 10:49:38]

It was a stupid mistake and it was working sometimes because of race conditions.

 }
 
 jobject NewJniArrayList(JNIEnv* env)
 {
   return env->NewObject(arrayListClass->Get(), arrayListCtor);
 }
 
 jmethodID JniGetAddToListMethod(JNIEnv* env, jobject list)
 {
   JniLocalReference<jclass> clazz(env, env->GetObjectClass(list));
@@ skipping 65 matching lines @@
 {
   return NewJniObject<AdblockPlus::Subscription>(
     env, std::move(subscription), subscriptionClass->Get(), subscriptionCtor);
 }
 
 jobject NewJniNotification(JNIEnv* env, AdblockPlus::Notification&& notification)
 {
   return NewJniObject<AdblockPlus::Notification>(
     env, std::move(notification), notificationClass->Get(), notificationCtor);
 }