Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java

Issue 29559597: Issue 5810 - Use "specialization" as Subscription display title (Closed)
Left Patch Set: Created Sept. 29, 2017, 11:54 a.m.
Right Patch Set: fix Created Sept. 29, 2017, 8:38 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 editor.putInt(SETTINGS_SUBSCRIPTIONS_KEY, settings.getSubscriptions().size ()); 202 editor.putInt(SETTINGS_SUBSCRIPTIONS_KEY, settings.getSubscriptions().size ());
203 203
204 // each subscription 204 // each subscription
205 for (int i = 0; i < settings.getSubscriptions().size(); i++) 205 for (int i = 0; i < settings.getSubscriptions().size(); i++)
206 { 206 {
207 Subscription eachSubscription = settings.getSubscriptions().get(i); 207 Subscription eachSubscription = settings.getSubscriptions().get(i);
208 208
209 // warning: saving `title`, `url` and `specialization` fields only 209 // warning: saving `title`, `url` and `specialization` fields only
210 editor.putString(getSubscriptionTitleKey(i), eachSubscription.title); 210 editor.putString(getSubscriptionTitleKey(i), eachSubscription.title);
211 editor.putString(getSubscriptionURLKey(i), eachSubscription.url); 211 editor.putString(getSubscriptionURLKey(i), eachSubscription.url);
212 editor.putString(getSubscriptionSpecializationKey(i), eachSubscription.u rl); 212 editor.putString(getSubscriptionSpecializationKey(i), eachSubscription.s pecialization);
diegocarloslima 2017/09/29 14:27:20 Shouldn't it be `eachSubscription.specialization`
anton 2017/09/29 20:39:35 Yes, sure. Silly mistake.
213 } 213 }
214 } 214 }
215 } 215 }
216 } 216 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld