Issue 5763 - Target languages supported by Firefox

packagerChrome.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import errno
 import io
 import json
 import os
 import re
 from StringIO import StringIO
@@ skipping 200 matching lines @@
             value = value[0:index] + value[index + 1:]
 
     data[key] = {'message': value}
 
 
 def import_locales(params, files):
     for item in params['metadata'].items('import_locales'):
         filename, keys = item
         for sourceFile in glob.glob(os.path.join(os.path.dirname(item.source),
                                                  *filename.split('/'))):
-            locale = sourceFile.split(os.path.sep)[-2].replace('-', '_')

[Sebastian Noack, 2017/10/05 19:01:43]

Replacing dashes with underscore here is only necessary to support the BCP-47
format. Pelase remove this replacement with your patch that removes support for
the BCP-47 format.

+            parts = sourceFile.split(os.path.sep)

[Sebastian Noack, 2017/10/05 20:58:38]

I just noticed that the variable "parts" is used below. I didn't notice before,
because it's only used in the branch for legacy Gecko extensions below.

@Tristan: Feel free to remove this variable again when removing support for
legacy Gecko extensions.

[tlucas, 2017/10/06 08:53:53]

Acknowledged.

+            locale = parts[-2].replace('-', '_')
             targetFile = os.path.join('_locales', locale, 'messages.json')
             data = json.loads(files.get(targetFile, '{}').decode('utf-8'))
 
             try:
                 # The WebExtensions (.json) and Gecko format provide
                 # translations differently and/or provide additional
                 # information like e.g. "placeholders". We want to adhere to
                 # that and preserve the addtional info.
                 if sourceFile.endswith('.json'):
                     with io.open(sourceFile, 'r', encoding='utf-8') as handle:
@@ skipping 169 matching lines @@
                 params, 'testIndex.html.tmpl', ('general', 'testScripts')
             )
 
     zipdata = files.zipToString()
     signature = None
     pubkey = None
     if keyFile != None:
         signature = signBinary(zipdata, keyFile)
         pubkey = getPublicKey(keyFile)
     writePackage(outFile, pubkey, signature, zipdata)